From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 14062@debbugs.gnu.org
Subject: bug#14062: 24.3.50; emacs_backtrace.txt
Date: Sat, 04 May 2013 20:59:46 +0200 [thread overview]
Message-ID: <51855AA2.1060705@gmx.at> (raw)
In-Reply-To: <83txmilw73.fsf@gnu.org>
> Sorry, I was actually talking about something else entirely: about
> this:
>
> + !NILP (BVAR (XBUFFER ((W)->contents), mode_line_format))
>
> As for FRAME_WANTS_MODELINE_P, it's zero for minibuffer frames and
> tooltip frames. Are you saying that these frames should be able to
> have header lines?
No. As far as minibuffer frames are concerned, these should be excluded
by the !MINI_WINDOW_P ((W)) conjunct since make_minibuffer_frame sets
XWINDOW (mini_window)->mini = 1. I forgot about tooltip windows though.
Note that frame.h has this
/* 0 means, if this frame has just one window,
show no modeline for that window. */
unsigned wants_modeline : 1;
and we set this to 0 in make_minibuffer_frame but we don't set this for
tooltip frames - that's why I didn't find it in the first place.
Moreover, the comment insinuates that when the frame has two windows we
might want to show a modeline so WINDOW_WANTS_MODELINE_P would have to
check that (I doubt that such frames exist in practice though).
Finally, frame.h also has this comment
/* Not really implemented. */
#define FRAME_WANTS_MODELINE_P(f) (f)->wants_modeline
which only adds to my confusion.
martin
next prev parent reply other threads:[~2013-05-04 18:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 23:33 bug#14062: 24.3.50; emacs_backtrace.txt Drew Adams
2013-03-27 6:57 ` Eli Zaretskii
2013-03-27 9:45 ` Dani Moncayo
2013-03-27 12:20 ` Eli Zaretskii
2013-03-27 13:39 ` Drew Adams
2013-03-28 9:25 ` Eli Zaretskii
2013-04-15 7:35 ` Eli Zaretskii
2013-04-15 11:54 ` Juanma Barranquero
2013-04-15 12:30 ` Eli Zaretskii
2013-04-15 12:40 ` martin rudalics
2013-04-15 14:18 ` Eli Zaretskii
2013-04-15 15:53 ` martin rudalics
2013-04-15 16:21 ` Eli Zaretskii
2013-04-15 19:22 ` martin rudalics
2013-04-16 6:08 ` Eli Zaretskii
2013-04-22 16:04 ` Drew Adams
2013-04-22 16:12 ` Juanma Barranquero
2013-04-22 18:05 ` Eli Zaretskii
2013-04-22 18:18 ` Drew Adams
2013-05-04 10:27 ` Eli Zaretskii
2013-05-04 12:27 ` martin rudalics
2013-05-04 12:33 ` Eli Zaretskii
2013-05-04 12:45 ` martin rudalics
2013-05-04 13:18 ` Eli Zaretskii
2013-05-04 18:59 ` martin rudalics [this message]
2013-05-04 14:38 ` Drew Adams
2013-03-27 13:37 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51855AA2.1060705@gmx.at \
--to=rudalics@gmx.at \
--cc=14062@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).