From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#14233: 24.3; Don't constrain frame size to character multiples Date: Tue, 23 Apr 2013 08:52:08 +0200 Message-ID: <51762F98.9060505@gmx.at> References: <2r7gjy2gyy.fsf@fencepost.gnu.org> <83bo991z00.fsf@gnu.org> <517257A0.4080607@gmx.at> <071A708E-3A98-4D11-A15F-7AB92D5200DD@swipnet.se> <51727563.70905@gmx.at> <5172908F.7090206@swipnet.se> <83sj2lz6nm.fsf@gnu.org> <5172EBEF.7030301@swipnet.se> <5173B0D8.4010408@gmx.at> <9CE9273D-8550-478F-8CB9-0C0D693C0BB8@swipnet.se> <5175042E.5020508@gmx.at> <5064BF03-8A61-4C0E-AA6C-5197A177B61A@swipnet.se> <517558ED.7080907@gmx.at> <5175679B.8010903@gmx.at> <83ehe2xw7q.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1366699993 18091 80.91.229.3 (23 Apr 2013 06:53:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Apr 2013 06:53:13 +0000 (UTC) Cc: esabof@gmail.com, 14233@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 08:53:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UUX6K-0008Us-RT for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2013 08:53:16 +0200 Original-Received: from localhost ([::1]:36531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUX6K-0006IO-Hu for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2013 02:53:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUX6G-0006IJ-MH for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2013 02:53:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUX6B-0002RT-K5 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2013 02:53:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUX6B-0002RE-GL for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2013 02:53:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UUXAw-0004sF-40 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2013 02:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2013 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14233-submit@debbugs.gnu.org id=B14233.136670023818638 (code B ref 14233); Tue, 23 Apr 2013 06:58:02 +0000 Original-Received: (at 14233) by debbugs.gnu.org; 23 Apr 2013 06:57:18 +0000 Original-Received: from localhost ([127.0.0.1]:38173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UUXAD-0004qY-C5 for submit@debbugs.gnu.org; Tue, 23 Apr 2013 02:57:17 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:60347) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UUXAA-0004qL-LF for 14233@debbugs.gnu.org; Tue, 23 Apr 2013 02:57:16 -0400 Original-Received: from mailout-de.gmx.net ([10.1.76.34]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0Lbx7K-1Utvfi1VXo-00jIj6 for <14233@debbugs.gnu.org>; Tue, 23 Apr 2013 08:52:18 +0200 Original-Received: (qmail invoked by alias); 23 Apr 2013 06:52:18 -0000 Original-Received: from 62-47-40-54.adsl.highway.telekom.at (EHLO [62.47.40.54]) [62.47.40.54] by mail.gmx.net (mp034) with SMTP; 23 Apr 2013 08:52:18 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+oBBoyac2oTMPkP//COv8/1FFNGvB/AVQ+JUP59x kqANnqf1BA4Sk7 In-Reply-To: <83ehe2xw7q.fsf@gnu.org> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73598 Archived-At: >> change_frame_size has no idea whether it is called for a text or a >> graphical frame. > > That is done very easily, given the frame pointer (which > change_frame_size accepts as its 1st argument). E.g.: > > if (FRAME_WINDOW_P (f)) > /* do the GUI thing */ A couple of weeks ago I asked you whether HAVE_WINDOW_SYSTEM would be sufficient but got no answer :-( The problem is that I'm still not sure whether FRAME_WINDOW_P is sufficient. At least in frame.c all FRAME_WINDOW_P calls are guarded by HAVE_WINDOW_SYSTEM checks as #ifdef HAVE_WINDOW_SYSTEM if (FRAME_WINDOW_P (XFRAME (this))) ... #endif so some doubt remains whether this predicate is correctly installed on every platform. In any case I'd want either an #ifdef or a simple and robust predicate without having to care about #ifdefs. >> Text frames might want to call it as before using character sizes. > > On text-mode frames, each character is one pixel. Emacs knows that > already. In the past weeks I started to doubt whether Emacs really knows everything it pretends to know. >> In any case, the callers have to strip space used for tool- or >> menubars because change_frame_size does not know whether these are >> part of the frame or not. > > Why can't change_frame_size know that? The callers should know best whether a toolbar is part of their frames or not. But we could obviously teach change_frame_size to check that. martin