From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#14233: 24.3; Don't constrain frame size to character multiples Date: Sat, 20 Apr 2013 14:56:47 +0200 Message-ID: <5172908F.7090206@swipnet.se> References: <2r7gjy2gyy.fsf@fencepost.gnu.org> <83bo991z00.fsf@gnu.org> <517257A0.4080607@gmx.at> <071A708E-3A98-4D11-A15F-7AB92D5200DD@swipnet.se> <51727563.70905@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1366462651 8469 80.91.229.3 (20 Apr 2013 12:57:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Apr 2013 12:57:31 +0000 (UTC) Cc: esabof@gmail.com, 14233@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 20 14:57:35 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UTXMB-0001ZM-1F for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2013 14:57:31 +0200 Original-Received: from localhost ([::1]:35989 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTXMA-0002qN-8h for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2013 08:57:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTXM5-0002q4-ID for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2013 08:57:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTXM3-0002oJ-F2 for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2013 08:57:25 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTXM3-0002o1-9Z for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2013 08:57:23 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UTXQY-00012E-7I for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2013 09:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Apr 2013 13:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14233-submit@debbugs.gnu.org id=B14233.13664628953876 (code B ref 14233); Sat, 20 Apr 2013 13:02:02 +0000 Original-Received: (at 14233) by debbugs.gnu.org; 20 Apr 2013 13:01:35 +0000 Original-Received: from localhost ([127.0.0.1]:33268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UTXQ6-00010S-U8 for submit@debbugs.gnu.org; Sat, 20 Apr 2013 09:01:35 -0400 Original-Received: from mailout.melmac.se ([62.20.26.67]:62164) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UTXQ3-000106-E8 for 14233@debbugs.gnu.org; Sat, 20 Apr 2013 09:01:32 -0400 Original-Received: from mail01.melmac.se (mail01.melmac.se [62.20.26.80]) by mailout.melmac.se (Postfix) with ESMTP id 7C390C933 for <14233@debbugs.gnu.org>; Sat, 20 Apr 2013 14:56:48 +0200 (CEST) Original-Received: (qmail 21670 invoked by uid 89); 20 Apr 2013 12:55:58 -0000 Original-Received: from h-46-59-42-18.na.cust.bahnhof.se (HELO coolsville.localdomain) (boel.djarv@bdtv.se@46.59.42.18) by mail01.melmac.se with ESMTPA; 20 Apr 2013 12:55:58 -0000 Original-Received: from [172.20.199.2] (gaffa [172.20.199.2]) by coolsville.localdomain (Postfix) with ESMTP id E7C587FA058; Sat, 20 Apr 2013 14:56:47 +0200 (CEST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 In-Reply-To: <51727563.70905@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73515 Archived-At: Hello. 2013-04-20 13:00, martin rudalics skrev: > >> - An option `frame-resize-pixelwise' which, when non-nil, passes resize > >> requests from the window manager pixelwise to the frame and window > >> resizing routines. > [...] > > How does these interact with WM size hints? Are you turning them off when > resizing pixelwise? > > No. But I've tested this on Windows only where in an initial stage I > did in x_wm_set_size_hint > > SetWindowLong (window, WND_FONTWIDTH_INDEX, 1); > SetWindowLong (window, WND_LINEHEIGHT_INDEX, 1); > > which worked. But later I found out that this was not needed - all I > had to do was turning off rounding in the case of WM_WINDOWPOSCHANGING > in w32_wnd_proc. > > So you will probably have to tell me on which platforms turning off WM > size hints is needed. We should not turn off WM size hints on any platform IMHO. If we do that, the resize feedback from the window manager shows pixels instead of rows x columns. The latter is much more useful. I don't understand why we want to resize in pixels instead of characters. But if you insist on resizing with pixels instead of characters, you have turn WM hints off for NS and X. You should thoroughly test this change on X with a couple of different window manager before checking it in. Resizing is a bit of a mess on X because the intreactions with the window manager, and the strange ways Emacs deals with GUI elements. > > > Are you proposing that the width of the scroll bar and the fringe be > included in the text width? You need to explain this better. > > Yes. Have you tried the scenario of bug#14222 ? I think it's a direct > consequence of the dichotomy that OT1H we do want changing fringe widths > affect the size of the frame on the screen but OTOH do not want these > changes to have any impact immediately. > > BTW: When the toolbar is part of the frame we do include its height in > the frame's text height (obviously so, because otherwise wrapping the > toolbar would resize the frame) and IIUC we always include margins in > the frame's text width but do refuse to so with fringes and scrollbars. I'd rather see that text is text. Fringe and scrollbars should not be included, nor should margins or borders. Non-text portions should be able to have any width/height in pixels. This includes the native toolbar. But I'd prefer if the text part is resizable only in terms of lines/columns. An exception to this is tiling window managers and fullscreen behaviour. So resizing fringes and scrollbars ought to resize the frame. > > > This is dependent on the port. For the Gtk+ port, toolbar and menubar > height has no restriction to be in lines. A value > 0 means "on". The actual > height is not the height of a line, but whatever height the toolkit chooses. > > I know. I just wanted to know whether we should do that on other ports > as well and how to specify that. IMHO we should do that on all ports. Jan D.