From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Marino Newsgroups: gmane.emacs.bugs Subject: bug#14068: [PATCH] Officially support DragonFly BSD Date: Thu, 18 Apr 2013 09:59:47 +0200 Message-ID: <516FA7F3.8070704@marino.st> References: <5152F41B.1090707@marino.st> <515C2D07.5010208@marino.st> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1366272058 25320 80.91.229.3 (18 Apr 2013 08:00:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Apr 2013 08:00:58 +0000 (UTC) Cc: 14068@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 18 10:01:02 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1USjm6-0001JC-Mv for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Apr 2013 10:00:58 +0200 Original-Received: from localhost ([::1]:33538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjm6-0006di-D7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Apr 2013 04:00:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjlq-0006ZD-OJ for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2013 04:00:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USjlk-0003UK-1j for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2013 04:00:42 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjlj-0003U2-SF for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2013 04:00:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1USjq2-0000JN-5Y for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2013 04:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Marino Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2013 08:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14068-submit@debbugs.gnu.org id=B14068.13662722661064 (code B ref 14068); Thu, 18 Apr 2013 08:05:02 +0000 Original-Received: (at 14068) by debbugs.gnu.org; 18 Apr 2013 08:04:26 +0000 Original-Received: from localhost ([127.0.0.1]:57990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1USjpR-0000H0-MJ for submit@debbugs.gnu.org; Thu, 18 Apr 2013 04:04:26 -0400 Original-Received: from mail.synsport.com ([208.69.230.148]:45652 helo=shepard.synsport.net) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1USjpN-0000Gg-Rz for 14068@debbugs.gnu.org; Thu, 18 Apr 2013 04:04:22 -0400 Original-Received: from [10.31.9.210] (unknown [213.225.137.129]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 231C443BF6; Thu, 18 Apr 2013 02:59:51 -0500 (CDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20120129 Thunderbird/10.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73487 Archived-At: On 4/18/2013 07:46, Glenn Morris wrote: > John Marino wrote: > >> The previously submitted patch was for release 24.3. >> The patch to add DragonFly support to version 24.3.50.112178 is much >> smaller: >> https://raw.github.com/jrmarino/DPorts/staged/editors/emacs-devel/dragonfly/patch-configure.ac > > + case "${canonical}" in > + i[3456]86-*-dragonfly*) machine=intel386 ;; > + amd64-*-dragonfly*|x86_64-*-dragonfly*) machine=amdx86-64 ;; > + esac > > machine is no longer used, so these lines are unnecessary. Okay, good to know! > > - freebsd) LIBS_SYSTEM="-lutil" ;; > + freebsd|netbsd|openbsd|dragonfly) LIBS_SYSTEM="-lutil" ;; > > Why are you adding netbsd and openbsd as well? It was likely left over from years. The submitted patch came from pkgsrc and freebsd ports. It is appropriate to only add DragonFly (as you have done) and let representatives from the other BSDs speak for themselves. > > Apart from that, it seems fine to me. > It's probably just small enough not to need a copyright assignment; but > for the ChangeLog, can you tell me who the author is? I think it's reasonable to call me (John Marino) the primary author. I basically had to create it from scratch -- most of this information was in those "S" files and had to be moved to the configure script, so it's basically new. > > Revised patch against current trunk: With a quick glance, it looks good to me. Thanks! John