From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list Date: Tue, 7 Jan 2025 22:18:53 -0800 Message-ID: <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> References: <87h66e8u59.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1959"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75362@debbugs.gnu.org, Roi Martin To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 08 07:20:16 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVPQN-0000Jp-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jan 2025 07:20:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVPQD-0004Fz-2k; Wed, 08 Jan 2025 01:20:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVPQB-0004Ev-Sj for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 01:20:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVPQB-0000RH-HW for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 01:20:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=/c2zCtuPOCoTrOPrO8Aj57P1aNh7xdhFONwkoO//Ogc=; b=kpJ3tv/xE+vY8lWmMWUowrIXBGm3r7xHeu6Z0PkaxH5ComuiRzp07rO26tNQP7Y2ZGhfAoPIdgxQvAGgE/Y09zEYICJk4F/5NWYsNOc6p0kW8zdFdcYeOBlBQgqd6fRDbPa95iU1vkT9ronZ8U9fqInrMkuACN63Zp0OhWYf7nMk0p3cojozHvcdvDhnZY9JzEg0yVX3R5NXyZkVi5BZgs8a4mK5iA/O7t7X9zCjRp+7qbAhIzB4NfH4vQ72seV9WujB5mmAExpSQwfQfEUYiaBcFtMqmN8BxRNeHJtAGgw6GvaORmBPP6l/T6GKcwKsZT0qDBr894G1HuW7NPqCgQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVPQA-0008DR-En for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 01:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2025 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75362 X-GNU-PR-Package: emacs Original-Received: via spool by 75362-submit@debbugs.gnu.org id=B75362.173631715231489 (code B ref 75362); Wed, 08 Jan 2025 06:20:02 +0000 Original-Received: (at 75362) by debbugs.gnu.org; 8 Jan 2025 06:19:12 +0000 Original-Received: from localhost ([127.0.0.1]:45727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVPPM-0008Bp-AE for submit@debbugs.gnu.org; Wed, 08 Jan 2025 01:19:12 -0500 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:49344) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVPPL-0008BX-BY for 75362@debbugs.gnu.org; Wed, 08 Jan 2025 01:19:11 -0500 Original-Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-21634338cfdso29288925ad.2 for <75362@debbugs.gnu.org>; Tue, 07 Jan 2025 22:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736317145; x=1736921945; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/c2zCtuPOCoTrOPrO8Aj57P1aNh7xdhFONwkoO//Ogc=; b=KuHAZ3vrSBZWIYhYsd0ANyWIjh8ke0beitYjAZTQEqc6Xns5Y5eyLPCxg7W/+dDQfV JrUhqu6JjSxJC+EF62f0aPbt6uDtLFSTYSmXz1LwJhH1Yv7socU0QNin3et+hhK3FJNI rgj0ra/Uj1CkfIIrVzry14YbVZCao0DbhPF4VEc1Y4bt5Cp6pgzp/pFhvo0wkecajgC9 3maCxEoqp1/yyp5WUEyxWubo8eq0566OkqlciqBb9vC1tHgFVmVW7fdf1n6sT5FKwDTN qiq+FDAbe5fnFT5eZcscsgQT5Jtx1doluHWbETeF8AUR12nfGV43eOq2BLKXEZn9EZUo lwcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736317145; x=1736921945; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/c2zCtuPOCoTrOPrO8Aj57P1aNh7xdhFONwkoO//Ogc=; b=qZKttWLdtrZlwU3AHLztU07k+ONuwNRQDNcz1GgDoS51ahGUm83P9s7KPa0u6KNUiN ULcHzIwterSRpSpZ3b9UjR/MmrHfyNvl1e7O7kbEbMGqmwk4DzJYXimSctyh/aEU4Frm asjhGI2G0wrWl1VrPtAfQYWXf/aovzMVLLHPTr3VvWDQw0q+OrrLLW6bxcqBI4I61jpi iup8JeqHqF/tRht5GhdGKwoI6R3webdjO7/JcRHD9JeGpmEr8sp6guyql13KkxJ0Rcpc pX55suFYfmcstc1M1lZjG5X5uT3Pi8Nsn6M8l9uubLE5YkLGUII1lStzo2xzWZRkP18x ghrA== X-Forwarded-Encrypted: i=1; AJvYcCVC3TVV0x4Nwv6IDoRmE966g0BdwA9/YU7PAuUBWoP6H2R/CoWs4CF816NBkzE4mUXFMTk29w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyqwjtdQba7WCe/ZXL8AGjSHZIaKuY7cBW4Dqs6RAhSaqt+KnBS dBjwDwmZQeJxjWTPP51AIQgBrM6ClSYr9eMfWZ7cR1LnJ8uwTpm9XO0M9Q== X-Gm-Gg: ASbGncs392jBMmPrF3e5/A5sWU/aNG1R38KCJuR2WSc1Ol1lDuei/RnYqH/MIjo74mO wLsd+kjuWPOLXklx3kL91lFj4sr6otrexiAamNHakf6J+jKrfQvbSf1TwMZQ0d0MdL7QkESA64/ W8/3iKDvccRddYvqEp4Fbs+eJuBWwnlC4eeQ1zs1uQqyO+pAf0pdRtgQgPsWKgLgru3cwGTrUUI qxgIEM0A7IQzTrPEaNtdHkguObyCSfskUoT8dIyYgl29bcuLbfq4WaTHSpfJJq1WiamsZnfeIhI +85r X-Google-Smtp-Source: AGHT+IHdLsI71kUfD5K8hRAe+JioKQQfzhaXgPb44ip+V5NAYd1d61aRsW15ToNLgHNKpq4Xvf3DcA== X-Received: by 2002:a05:6a20:7350:b0:1e0:cc4a:caab with SMTP id adf61e73a8af0-1e88d12c1e2mr3048509637.19.1736317145149; Tue, 07 Jan 2025 22:19:05 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:715c:1de9:341d:f41d]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e414dbbasm26798123a12.82.2025.01.07.22.19.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2025 22:19:04 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298759 Archived-At: > On Jan 5, 2025, at 2:05=E2=80=AFPM, Randy Taylor wrote: >=20 > On Saturday, January 4th, 2025 at 10:40, Roi Martin = wrote: >>=20 >> When using the Go tree-sitter grammar v0.23.4 from >> https://github.com/tree-sitter/tree-sitter-go.git, indentation inside >> var lists does not work correctly. >>=20 >> For instance, the following code is indented as: >>=20 >> `var ( one =3D 1 )` >>=20 >> Instead of: >>=20 >> `var ( one =3D 1 )` >>=20 >> Just in case it can help, I think this stopped working with grammar >> version `v0.21.1`, that introduced `var_spec_list`: >>=20 >> = https://github.com/tree-sitter/tree-sitter-go/compare/v0.21.0...v0.21.1 >>=20 >> Please, take it with a pinch of salt because I'm not very familiar = with >> tree-sitter. >>=20 >> [...] >>=20 >=20 > Thanks for the report. >=20 > The attached patch fixes it for = me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch> Thanks Randy. Eli, should we apply this to emacs-30. Also, what=E2=80=99s the general situation of grammar fixes on emacs-30? = I=E2=80=99m asking because I fixed a grammar compatibility issue for = cmake-ts-mode on master. I was going to back port it for 30.2, but it = seems that simple fixes are ok for emacs-30? Yuan=