From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51993: 29.0.50; [PATCH] Killing emacsclient terminal with `server-stop-automatically' doesn't prompt to save files Date: Mon, 29 Nov 2021 11:12:22 -0800 Message-ID: <514c9cb1-aa94-4332-0740-ad51310c2014@gmail.com> References: <9e47c871-a2c3-d764-bec9-d87abf3efe83@gmail.com> <79a53ecc-dbfc-d088-d80d-96f349be794a@gmail.com> <834k7vw2vb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40045"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 29 20:18:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrmAd-000AAx-D4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Nov 2021 20:18:35 +0100 Original-Received: from localhost ([::1]:41884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrmAc-00035s-Dj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Nov 2021 14:18:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrm5G-00065g-V5 for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2021 14:13:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrm5F-0000oW-Sz for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2021 14:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrm5F-0000be-Ia for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2021 14:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Nov 2021 19:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51993-submit@debbugs.gnu.org id=B51993.16382131522294 (code B ref 51993); Mon, 29 Nov 2021 19:13:01 +0000 Original-Received: (at 51993) by debbugs.gnu.org; 29 Nov 2021 19:12:32 +0000 Original-Received: from localhost ([127.0.0.1]:39408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrm4l-0000aw-L1 for submit@debbugs.gnu.org; Mon, 29 Nov 2021 14:12:31 -0500 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:36810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrm4k-0000ak-B5 for 51993@debbugs.gnu.org; Mon, 29 Nov 2021 14:12:30 -0500 Original-Received: by mail-pj1-f44.google.com with SMTP id n15-20020a17090a160f00b001a75089daa3so16371679pja.1 for <51993@debbugs.gnu.org>; Mon, 29 Nov 2021 11:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=kdzVLmq/nduj45T7h0M0JK+6rh/OacwjfNxtCaKjoDQ=; b=nrhAnf20dfWZJ7kyHKRLyfbN7gEs3T6lgyJIcKlmccuWi9v88IqW1w29IXBI+QyZjj pY7Q/L48FsN5sOADAb4dePV338UURnj/ERnHr6nVo+d68Jj8+a6u0GGabtx0na3leP7p 81fAyAQOGwtzXbkzaqTcU1uKGLrxzMAtN9fAEcC+3pyC83WaaPcIOSFpBJ63Y4B24lCi DqfvG2aAY11UuaNmpUgxIk478KfAhXbEp06O5COYIsWpXCAJWWA3L1HpaCvnLsmUU5Bd bZvN38vokV8CneilCtr5hV/4WMsrbfguZSuolT1IcRl7efACcex9LRmhUbF+DJQ2f76e +alQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kdzVLmq/nduj45T7h0M0JK+6rh/OacwjfNxtCaKjoDQ=; b=Sa3SzKhqeZyUlYrVCtIYAq4H6wF57sAGGCEVZLCfojbGSMv/ciDZkrlhMpRB8Bglbq u3zb9oBQ2dndle/ajkRpWgcRvEJR0DxxHo55J6939bjFuCqaPNiXmLKrwVX6A6Bx2CDv jU0c1UYoyYKBj7k/BCI1/Ab7Xl9hlX+17H/tcwFPhIaRhm5XVOdHGTDycQQYIQipinbJ fUrfRehRch/SX6wiIr9aiArN2hjC46oPNh9pJC1EUSayMlr3Czji+46YJTYCqYEQgelz 98JG8+E7ZXp5zsSKlIbtUloNS/BcquaFuVd6xF9ud2kJbmadUrl8v9aCf9ex8m0x91ty 4MHg== X-Gm-Message-State: AOAM5334RrHhTloEwDA3HrbvMc+Cz+X12zxgl9bqg15UO47su9WH41BL jfwI8KLF/dEDB09wCY/CGP0= X-Google-Smtp-Source: ABdhPJwPAhOdBCN7QIW+Ti0aN2+ixkXANpyBw0otU+9zhIeys+EUo7eK+TkTCEu6QVYIcW8hazgMAA== X-Received: by 2002:a17:90a:d515:: with SMTP id t21mr275380pju.123.1638213144652; Mon, 29 Nov 2021 11:12:24 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id oa17sm102712pjb.37.2021.11.29.11.12.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Nov 2021 11:12:23 -0800 (PST) In-Reply-To: <834k7vw2vb.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221071 Archived-At: On 11/29/2021 4:41 AM, Eli Zaretskii wrote: > However, I'm not sure I understand the way forward, as you see it. > AFAIU, there are fundamental disagreements between you and Gregory, > and I don't think the disagreements are there because one of you > doesn't understand the proposals of the other. I think there may be some of both. Since, from Gregory's perspective I've been changing what I want, and from my perspective I've always wanted the same thing, it seems that there's at least some miscommunication happening. Hopefully my proposal helps to explain my position more clearly (and in a single message, rather than scattered across several). There may still be some disagreements, and I'm happy to incorporate anything I've missed into the proposal if people would find that useful. On the other hand, if it's easier to just work on a patch that everyone would be happy with (or at least be able to tolerate), that's ok too. > So how could these disagreements be reconciled? Either you-two come > up with some compromise that is acceptable by both of you, or Lars and > myself make the decision for you (and we don't guarantee you will like > it), or things are left as they are now. What will it be? Hopefully Gregory and I can reach a compromise; the Implicit Shutdown case in my proposal is an initial attempt at incorporating Gregory's desired behavior (it was the behavior Gregory first proposed in the thread on emacs-devel). I'm primarily interested in the Explicit Shutdown case though; I may have missed some things in that section as well, but like I said, I'm happy to add more to it if anyone has things they'd like to be added. That said, no matter if Gregory and I can reach a compromise, I think it would be helpful if you and/or Lars could take a look if you have time to be sure the behavior makes sense to you and that it's something you'd want to be in Emacs. Since this might have relevance for other Emacs features (e.g. emacsclient.desktop[1]), I think it would be good to have as many experienced eyes on this as possible. In the end, so long as everyone is clear what the behavior should be, and that it's documented as such so there's no confusion about what's a bug and what's intended behavior, then I don't have any (major) problems. Obviously, I'd be happy if my preferred behavior were a part of Emacs, but if you and Lars don't think it should be, then I can just continue what I've been doing: add advice to the necessary server.el functions in my config so things work how I like. [1] https://lists.gnu.org/archive/html/emacs-devel/2021-10/msg01846.html