unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#13875: 24.3.50; whitespace-mode should use 'prepend for whitespace-line face
@ 2013-03-05 16:36 Dmitry Gutov
  2013-03-17 22:27 ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Gutov @ 2013-03-05 16:36 UTC (permalink / raw)
  To: 13875

Tags: patch

Right now, there's no way to tell whitespace-mode to keep the foreground
color of the underlying text when highlighting lines that are too long.

Related SO question:
http://stackoverflow.com/questions/14636786/how-to-unset-the-foreground-color-of-whitespace-mode-for-emacs

With the patch at the bottom applied, the following code will make it
keep the text's foreground and just change background:

  (set-face-attribute 'whitespace-line nil :foreground nil
                                           :background "gainsboro")

(Changing :backround is not necessary, but gray20 looks bad with the
default foreground color.)

=== modified file 'lisp/whitespace.el'
--- lisp/whitespace.el	2013-01-11 23:08:55 +0000
+++ lisp/whitespace.el	2013-03-05 16:25:51 +0000
@@ -2291,7 +2291,7 @@
 	 (if (memq 'lines whitespace-active-style)
 	     0				; whole line
 	   2)				; line tail
-	 whitespace-line t))
+	 whitespace-line 'prepend))
        t))
     (cond
      ((memq 'space-before-tab whitespace-active-style)





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#13875: 24.3.50; whitespace-mode should use 'prepend for whitespace-line face
  2013-03-05 16:36 bug#13875: 24.3.50; whitespace-mode should use 'prepend for whitespace-line face Dmitry Gutov
@ 2013-03-17 22:27 ` Stefan Monnier
  2013-03-19  4:24   ` Dmitry Gutov
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2013-03-17 22:27 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: 13875

> -	 whitespace-line t))
> +	 whitespace-line 'prepend))

No objection on my part,


        Stefan





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#13875: 24.3.50; whitespace-mode should use 'prepend for whitespace-line face
  2013-03-17 22:27 ` Stefan Monnier
@ 2013-03-19  4:24   ` Dmitry Gutov
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Gutov @ 2013-03-19  4:24 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13875-done

Version: 24.4

On 18.03.2013 2:27, Stefan Monnier wrote:
>> -	 whitespace-line t))
>> +	 whitespace-line 'prepend))
>
> No objection on my part,

Thanks, installed.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-19  4:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 16:36 bug#13875: 24.3.50; whitespace-mode should use 'prepend for whitespace-line face Dmitry Gutov
2013-03-17 22:27 ` Stefan Monnier
2013-03-19  4:24   ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).