From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#13949: 24.3.50; `fill-paragraph' should not always put the buffer as modified Date: Thu, 14 Mar 2013 11:27:25 +0100 Message-ID: <5141A60D.7030707@easy-emacs.de> References: <83li9qir3i.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1363256875 15125 80.91.229.3 (14 Mar 2013 10:27:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Mar 2013 10:27:55 +0000 (UTC) To: 13949@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 14 11:28:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UG5OV-0008Ss-7A for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2013 11:28:19 +0100 Original-Received: from localhost ([::1]:35908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG5O8-0003fa-MJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2013 06:27:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG5O5-0003fV-0o for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 06:27:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UG5O3-0006Ay-Jw for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 06:27:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG5O3-0006Ar-Gh for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 06:27:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UG5PB-0003zk-Md for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 06:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2013 10:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.136325688315292 (code B ref -1); Thu, 14 Mar 2013 10:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Mar 2013 10:28:03 +0000 Original-Received: from localhost ([127.0.0.1]:52882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UG5OD-0003yZ-UM for submit@debbugs.gnu.org; Thu, 14 Mar 2013 06:28:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46281) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UG5OB-0003y4-Vw for submit@debbugs.gnu.org; Thu, 14 Mar 2013 06:28:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UG5Mw-0005zG-L3 for submit@debbugs.gnu.org; Thu, 14 Mar 2013 06:26:44 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:45483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG5Mw-0005zC-J8 for submit@debbugs.gnu.org; Thu, 14 Mar 2013 06:26:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG5Ms-0003cO-22 for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 06:26:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UG5Mn-0005xb-Ut for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 06:26:37 -0400 Original-Received: from moutng.kundenserver.de ([212.227.17.8]:57001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG5Mn-0005xV-LQ for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 06:26:33 -0400 Original-Received: from [192.168.178.21] (brln-4d0c1994.pool.mediaWays.net [77.12.25.148]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0Lmufk-1UwrlU0suq-00h2qK; Thu, 14 Mar 2013 11:26:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 In-Reply-To: X-Provags-ID: V02:K0:GWopmONpAg8QjauEiirpgsIhPLRPtqsdpViugNftOTH 0DLIQsu8NPnVr0SZCRjqo5ZC2Ji3X6oWVbXZStztLleUCOgseI zURWZVT93b8ga9VUsLl8n3biy9BD1egMvlAf2vqAbQ+FT55ovy Jfeymy9PC7rS0HR2mcgInwGVxQPTyT3y2QzA3fwXxIDYyiw+Q4 K/xIAj7DsKOOz5A0v8KBrVgLqZWkgUBoAQlDuJvff76xOY4+FE Oh32uPvishmW3IRxhxSIeOm7vsJEXsHp4xVzz5eCHWfy9+2gGx /LoIMOmdOyMwobPyMpVVB2vzETELw4fUfTT5G/w+0ODbwsz3wp 80As2WmlEEVAEilti+ZIAj2WcZ++A9Vjf/ZFVDi+Z X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72455 Archived-At: Am 14.03.2013 08:57, schrieb Dani Moncayo: >>> This seems a bug, since step #4 didn't make any change in the buffer >>> contents (the paragraph was already filled). >> >> Step #4 does change the buffer, because M-q doesn't know whether the >> paragraph is already filled, so it fills it anew each time. >> >> Emacs always behaved like that. > > Ah, Ok. > > Well, since the `fill-paragraph' command at step #4 leaved the buffer > with the same contents, flagging the buffer as modified was > unnecessary in this case. > > In general, I think that a command should flag the buffer as modified > only when the buffer contents at the end of the command were different > from the contents at the beginning of that same command. > > But, I don't know complex is that to implement, and perhaps that > complexity outweighs the benefits. Hi, don't think it's complex. AFAIU the changed-flag presently is set by some commands assumed to change the buffer without regard to the result - as shown. Should not be that complicated to copy the buffers contents into a temporary buffer in this case and check both buffers afterwards if being equal. IMHO it's worth to do that change wrt fill-commands. Best, Andreas > > I'll let you (maintainers) to judge this. Feel free to close this bug > if the change isn't worth the trouble. > > Thanks. >