From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#13907: 24.3.50; cygw32 build mishandles drag-n-dropped file with non-ASCII characters in name Date: Fri, 08 Mar 2013 13:25:21 -0800 Message-ID: <513A5741.8060804@dancol.org> References: <513A1D4D.5060908@cornell.edu> <8338w5zni7.fsf@gnu.org> <83vc91y6m4.fsf@gnu.org> <83txoly5ov.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2BLBOWQHHGMRCDJNCUJTN" X-Trace: ger.gmane.org 1362778530 15188 80.91.229.3 (8 Mar 2013 21:35:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Mar 2013 21:35:30 +0000 (UTC) Cc: 13907@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 08 22:35:54 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UE4xF-0003i7-GJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Mar 2013 22:35:53 +0100 Original-Received: from localhost ([::1]:41137 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE4wt-0001rK-AD for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Mar 2013 16:35:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE4wj-0001oK-V7 for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2013 16:35:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UE4o3-00022j-Ef for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2013 16:26:37 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE4o3-00022d-8v for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2013 16:26:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UE4og-0002an-27 for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2013 16:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Mar 2013 21:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13907 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13907-submit@debbugs.gnu.org id=B13907.13627779829908 (code B ref 13907); Fri, 08 Mar 2013 21:27:02 +0000 Original-Received: (at 13907) by debbugs.gnu.org; 8 Mar 2013 21:26:22 +0000 Original-Received: from localhost ([127.0.0.1]:40084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UE4o1-0002Zk-6T for submit@debbugs.gnu.org; Fri, 08 Mar 2013 16:26:21 -0500 Original-Received: from dancol.org ([96.126.100.184]:51091) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UE4ny-0002Zb-0d for 13907@debbugs.gnu.org; Fri, 08 Mar 2013 16:26:19 -0500 Original-Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[0.0.0.0]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1UE4nE-0002BR-UE; Fri, 08 Mar 2013 13:25:32 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 In-Reply-To: <83txoly5ov.fsf@gnu.org> X-Enigmail-Version: 1.5.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72248 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BLBOWQHHGMRCDJNCUJTN Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 3/8/2013 12:53 PM, Eli Zaretskii wrote: >> Date: Fri, 08 Mar 2013 22:33:07 +0200 >> From: Eli Zaretskii >> Cc: 13907@debbugs.gnu.org >> >> And one more question: what is the value of file-name _before_ it is >> passed to cygwin-convert-file-name-from-windows? Does it perhaps >> already have the U-umlaut replaced by a blank? >=20 > I think the problem is on the C level, not on the Lisp level. Take a > look at w32term.c:construct_drag_n_drop -- it uses ANSI version of > DragQueryFile to get the file name, then decodes it by DECODE_FILE. > But DECODE_FILE uses UTF-8 in the cygw32 build, so this is > inappropriate for decoding file names that come from Windows APIs. >=20 > Instead, in the cygw32 build, construct_drag_n_drop should use > DragQueryFileW and convert the file name to the internal Emacs > representation using from_unicode. >=20 Thanks for finding that! I've been swamped this week, and I haven't been = able to do any investigation. I'll see whether I can come up with a fix this week= end. ------enig2BLBOWQHHGMRCDJNCUJTN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (Cygwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlE6V0MACgkQ17c2LVA10VuH9ACgj7uhNcz7HBZ5Ptyo8V/fltD3 fTsAnjspj3O/6uvCeO2u7PXLhLPnlmdF =1Nw1 -----END PGP SIGNATURE----- ------enig2BLBOWQHHGMRCDJNCUJTN--