From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.bugs Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Date: Tue, 05 Feb 2013 08:54:05 +0400 Message-ID: <5110906D.7020406@yandex.ru> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1360040097 12839 80.91.229.3 (5 Feb 2013 04:54:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Feb 2013 04:54:57 +0000 (UTC) Cc: Lawrence Mitchell , 13623@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 05 05:55:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U2aYv-0000ei-F7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2013 05:55:17 +0100 Original-Received: from localhost ([::1]:59579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2aYc-0001Ou-V6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2013 23:54:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2aYZ-0001Oo-8Q for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 23:54:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U2aYY-0006gq-0X for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 23:54:55 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2aYX-0006gm-TC for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 23:54:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U2aZd-0003j6-TH for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 23:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Antipov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2013 04:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136004012214277 (code B ref 13623); Tue, 05 Feb 2013 04:56:01 +0000 Original-Received: (at 13623) by debbugs.gnu.org; 5 Feb 2013 04:55:22 +0000 Original-Received: from localhost ([127.0.0.1]:36686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2aYz-0003iE-I7 for submit@debbugs.gnu.org; Mon, 04 Feb 2013 23:55:22 -0500 Original-Received: from forward19.mail.yandex.net ([95.108.253.144]:56946) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2aYu-0003i3-Th for 13623@debbugs.gnu.org; Mon, 04 Feb 2013 23:55:19 -0500 Original-Received: from smtp17.mail.yandex.net (smtp17.mail.yandex.net [95.108.252.17]) by forward19.mail.yandex.net (Yandex) with ESMTP id BA9D41120A5D; Tue, 5 Feb 2013 08:54:06 +0400 (MSK) Original-Received: from smtp17.mail.yandex.net (localhost [127.0.0.1]) by smtp17.mail.yandex.net (Yandex) with ESMTP id 7A0CD1900214; Tue, 5 Feb 2013 08:54:06 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp17.mail.yandex.net (nwsmtp/Yandex) with ESMTP id s5f4UcLY-s6fStDjY; Tue, 5 Feb 2013 08:54:06 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1360040046; bh=jHb9Jzjf7Y2H/rjaHXJRFHLKx6GgTVimBoWL0tHdM44=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Dgg5W0TiiMHNsyNV5KUENtYok8RLT/uBUQVQ14GjFkWi25zBEgJdgvlCRj0aSuSqw s8XpwnhqY+1hsCyU7WjRp9u4FiALb1mGyGT9IQS16WneFJIhCCz3SjJuloEmpAFobz W+0LTfqoX9lZQuqGCZC8PlgJXi94NnWJauYQPu3o= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 In-Reply-To: <83vca89izh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70707 Archived-At: On 02/04/2013 07:49 PM, Eli Zaretskii wrote: > Dmitry, this bug and also 13626 were both caused by your changes in > revision 111647. While the reason for the changes was to use non-Lisp > objects for some fields, several hunks in the changeset had no > relation whatsoever to that, and were highly questionable. Example: > > - /* If showing the region, and mark has changed, we must redisplay > - the whole window. The assignment to this_line_start_pos prevents > - the optimization directly below this if-statement. */ > - if (((!NILP (Vtransient_mark_mode) > - && !NILP (BVAR (XBUFFER (w->buffer), mark_active))) > - != !NILP (w->region_showing)) > - || (!NILP (w->region_showing) > - && !EQ (w->region_showing, > - Fmarker_position (BVAR (XBUFFER (w->buffer), mark))))) > - CHARPOS (this_line_start_pos) = 0; Hm. Although this is an obvious bug, are you sure that we must redisplay the whole window even if the region doesn't span multiple lines? IIUC it should be enough to redisplay the current line only. Dmitry