From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#60423: 29.0.60; goto-address and shr/textsec don't play nicely together Date: Thu, 10 Oct 2024 16:46:16 -0700 Message-ID: <51018.1728603976@alto.camomileplus.org> References: <175894.1672372745@alto> <831qoh6j0i.fsf@gnu.org> <69964.1728432546@alto.camomileplus.org> <86jzeh4g7x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60423@debbugs.gnu.org, Stefan Monnier , stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 11 01:47:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sz2s6-00094E-L5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Oct 2024 01:47:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sz2rt-00047g-TL; Thu, 10 Oct 2024 19:46:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sz2rr-00047R-Lb for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 19:46:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sz2rr-0007jV-By for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 19:46:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-reply-to:From:To:Subject; bh=IWKDNUVpPo8y+yezaBYNNmfeD9/2fVlStJgv6CfYcPY=; b=oBEPKffa9kswboI8I9DSpGc1K8iaYRZy+S8QiiqCfzWl06NKe+b1UJfwI4d/5/3+Z0gz4yyF48hztHmmiSjviZuzVEjNRMvEglFSEXZFOXnRHfyYhV8LQdh1LpEa2XLqU57ymgF8Pg/uZZUR/IeUkKP6/vyowBCyqTQ1tgSPKOKYeKbr5sJU4gUgg630Vmp/jFo7eFiIW3HTAu/DipafTHN8kR3dV7N28FLrHvJfnRfGMLy+Xciwy4gJvpjlsUsHuZcKTzMO0vp3jpbAwxZvvcBWMRoX9IXrsH6IVNHwUbSOdFV6S+Ggpgspx2nr8YNHqHdBV5PkQSx9v3cehklXTw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sz2s2-0000oT-9c for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 19:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Oct 2024 23:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60423 X-GNU-PR-Package: emacs Original-Received: via spool by 60423-submit@debbugs.gnu.org id=B60423.17286039993088 (code B ref 60423); Thu, 10 Oct 2024 23:47:02 +0000 Original-Received: (at 60423) by debbugs.gnu.org; 10 Oct 2024 23:46:39 +0000 Original-Received: from localhost ([127.0.0.1]:60890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz2re-0000nk-OO for submit@debbugs.gnu.org; Thu, 10 Oct 2024 19:46:39 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:27016 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz2rc-0000nY-8N for 60423@debbugs.gnu.org; Thu, 10 Oct 2024 19:46:37 -0400 Original-Received: from alto.camomileplus.org (135-180-174-211.dsl.dynamic.sonic.net [135.180.174.211] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 49ANkGw0060799 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 10 Oct 2024 16:46:21 -0700 (PDT) (envelope-from kupfer@rawbw.com) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-211.dsl.dynamic.sonic.net [135.180.174.211] (may be forged) claimed to be alto.camomileplus.org In-reply-to: <86jzeh4g7x.fsf@gnu.org> Comments: In-reply-to Eli Zaretskii message dated "Wed, 09 Oct 2024 15:24:02 +0300." X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.91 Content-ID: <51017.1728603976.1@alto.camomileplus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293319 Archived-At: Eli Zaretskii wrote: > > From: Mike Kupfer [...] > > So I lean towards having goto-address leave text alone (don't set an > > overlay) if it finds text properties set for the text. > > Not just any properties: only 'face' properties, right? Hmm. shr-tag-a sets these properties, with shr-urlify doing most of the work: - face ('shr-link') - shr-url - button - category - help-echo - follow-link - mouse-face If the URL is suspicious, shr-tag-a also inserts a triangular warning symbol with a 'help-echo' property. So if I just care about conflicts between goto-address and shr, I guess I could just check for the 'shr-link' face. I'd prefer to have a more general test, so I think I want to check for any of - face - help-echo - mouse-face and maybe - button - follow-link as well. What do you think? thanks, mike