bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 3466 bytes --]

Tooltips in the pgtk branch behave erratically.

In the tool-bar when you hover an icon the tooltip often blinks
rapidly or does not appear and the button itself goes quickly between
hover/non-hover state. A similar behavior happens with the mode-line.

In the menu-bar they appear behind the menu itself and obscure the
hint in the tooltip.

Attached is a short video which I hope shows what I mean. In case the
attachment does not arrive it is available directly from
http://files.johnmuhl.space/Kooha-2021-04-27-12%3A02%3A38.webm

---

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.29, cairo version 1.17.4)
 of 2021-04-27 built on thelio
Repository revision: 66a36f1e5a323aed3d39db1044a1b71373123832
Repository branch: feature/pgtk
Windowing system distributor 'System Description: Fedora 34
(Workstation Edition)

Configured using:
 'configure --with-pgtk'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY
PDUMPER PGTK PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
XIM
GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search seq byte-
opt
gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-
parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs
cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/pgtk-win pgtk-win term/common-win tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-
bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet
lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript
charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit pgtk lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 51314 11250)
 (symbols 48 6592 1)
 (strings 32 18173 1512)
 (string-bytes 1 598869)
 (vectors 16 13361)
 (vector-slots 8 177963 9848)
 (floats 8 22 61)
 (intervals 56 195 0)
 (buffers 992 10))


[-- Attachment #2: Kooha-2021-04-27-12:02:38.webm --]
[-- Type: video/webm, Size: 766470 bytes --]

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[Yuuki Harano]

On Tue, 27 Apr 2021 12:32:51 -0500,
	john muhl <email@johnmuhl.mx> wrote:
> In the tool-bar when you hover an icon the tooltip often blinks
> rapidly or does not appear and the button itself goes quickly between
> hover/non-hover state. A similar behavior happens with the mode-line.

I recently merge latest master into feature/pgtk.
It might fix it. Please try again.

> In the menu-bar they appear behind the menu itself and obscure the
> hint in the tooltip.

I'll debug it.

-- 
Yuuki Harano

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Tue, 2021-05-04 at 01:46 +0900, Yuuki Harano wrote:
> I recently merge latest master into feature/pgtk.
> It might fix it. Please try again.

Unfortunately that did not fix it.

I notice though that the issue (in both the latest build and the
previous) seems to only appear with emacs on my primary display. If I
drag Emacs to my secondary display I cannot reproduce the issue. The
only difference between displays is that the primary has the default
GNOME top-bar. e.g.

- start emacs on PD; note the reported jitters
- drag that emacs window to SD; note the jittering stops
- quit emacs
- start emacs on SD; no jitter
- drag that emacs to PD; jittering starts

I guess this is a coincidence but thought might be worth mentioning.
(note: the tooltips appearing behind the menu issue is unaffected by
which display is in use)
> 

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Tue, 2021-05-04 at 01:46 +0900, Yuuki Harano wrote:
> > In the menu-bar they appear behind the menu itself and obscure the
> > hint in the tooltip.
> 
> I'll debug it.

I wonder if these tooltips are even needed; they mostly just restate
what the item under point already says. I browsed around a few of the
default GNOME apps (and a few non-default others) but could not find
any that display tooltips when hovering an item in a drop down menu
the way Emacs does.

Would just getting rid of them be an alternative to debugging the
visibility issue?

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 112 bytes --]

I tried GNOME on Xorg and none of the issues appear there. This is a
wayland only issue as far as I can tell.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[Yuuki Harano]

On Mon, 03 May 2021 12:47:19 -0500,
	john muhl <email@johnmuhl.mx> wrote:
>> I'll debug it.
> 
> I wonder if these tooltips are even needed; they mostly just restate
> what the item under point already says. I browsed around a few of the
> default GNOME apps (and a few non-default others) but could not find
> any that display tooltips when hovering an item in a drop down menu
> the way Emacs does.
> 
> Would just getting rid of them be an alternative to debugging the
> visibility issue?

Tooltips in emacs are written always for main windows, not menu windows,
and compositor thinks that stacking order should be:

(above)
- menu
- tooltip for main window
- main window
(below)

It is too hard to improve it...


If you don't need tooltips, you can do:
(tooltip-mode -1)

I think that jitters may stop by it.
-- 
Yuuki Harano

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[Eli Zaretskii]

> Date: Tue, 04 May 2021 16:23:51 +0900 (JST)
> From: Yuuki Harano <masm+emacs@masm11.me>
> Cc: 48069@debbugs.gnu.org
> 
> Tooltips in emacs are written always for main windows, not menu windows,
> and compositor thinks that stacking order should be:
> 
> (above)
> - menu
> - tooltip for main window
> - main window
> (below)
> 
> It is too hard to improve it...

Does that mean tooltips will not work well in the pgtk build?  That
would be a shame, I think.  Can we somehow work around this
peculiarity, so that tooltips for menus and tool-bar buttons work as
they do in the other builds?

Thanks.

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[Yuuki Harano]

On Tue, 04 May 2021 14:54:20 +0300,
	Eli Zaretskii <eliz@gnu.org> wrote:
> Does that mean tooltips will not work well in the pgtk build?

Yes..

> Can we somehow work around this
> peculiarity, so that tooltips for menus and tool-bar buttons work as
> they do in the other builds?

At least, I need information what widget the tooltip is on.
Currently, I can get only frame.

Or,
I may be able to set tooltip text to menu item in advance and
entrust gtk with handling tooltips.

I'll try the second way.
-- 
Yuuki Harano

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[Eli Zaretskii]

> Date: Tue, 04 May 2021 21:50:25 +0900 (JST)
> Cc: email@johnmuhl.mx, 48069@debbugs.gnu.org
> From: Yuuki Harano <masm+emacs@masm11.me>
> 
> > Can we somehow work around this
> > peculiarity, so that tooltips for menus and tool-bar buttons work as
> > they do in the other builds?
> 
> At least, I need information what widget the tooltip is on.
> Currently, I can get only frame.
> 
> Or,
> I may be able to set tooltip text to menu item in advance and
> entrust gtk with handling tooltips.
> 
> I'll try the second way.

Yes, that sounds like the better alternative.  But if it doesn't work,
please feel free to modify the infrastructure to add the information
you need, I think there should be no problem to have it in all builds,
even if it will go unused there.

Thanks.

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[Yuuki Harano]

On Mon, 03 May 2021 12:47:19 -0500,
	john muhl <email@johnmuhl.mx> wrote:
>> > In the menu-bar they appear behind the menu itself and obscure the
>> > hint in the tooltip.
>> 
>> I'll debug it.
> 
> I wonder if these tooltips are even needed; they mostly just restate
> what the item under point already says. I browsed around a few of the
> default GNOME apps (and a few non-default others) but could not find
> any that display tooltips when hovering an item in a drop down menu
> the way Emacs does.
> 
> Would just getting rid of them be an alternative to debugging the
> visibility issue?

I fixed "Tooltips behind menu" issue.  Please try latest feature/pgtk.

Also, I tested with external display, but I couldn't reproduce jitter issue.

-- 
Yuuki Harano

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Sun, 2021-05-09 at 00:57 +0900, Yuuki Harano wrote:
> 
> I fixed "Tooltips behind menu" issue.  Please try latest
> feature/pgtk.

Looks good here.

> Also, I tested with external display, but I couldn't reproduce
> jitter issue.

I can no longer reproduce this either. In the meantime GNOME was
upgraded to 40.1 so maybe it was just a transient bug in 40.0. 

bug#48069: 28.0.50; [feature/pgtk]; tooltips are jittery and sometimes obscured

[Yuuki Harano]

On Wed, 12 May 2021 10:48:03 -0500,
	john muhl <email@johnmuhl.mx> wrote:
> I can no longer reproduce this either. In the meantime GNOME was
> upgraded to 40.1 so maybe it was just a transient bug in 40.0. 

OK, I'll close this issue.

-- 
Yuuki Harano