From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Vinokurov Newsgroups: gmane.emacs.bugs Subject: bug#53242: [PATCH] unify reads from local_var_alist Date: Fri, 14 Jan 2022 00:23:42 +0000 Message-ID: <50d65dbc-f3d6-86fb-6a7c-9200a6525ec2@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------oxcdymuqZIqo6orjfYSjx9Eq" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31713"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 To: 53242@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 14 01:24:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8AO2-00082G-1l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 01:24:10 +0100 Original-Received: from localhost ([::1]:40120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8AO0-0007Fw-Jq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 19:24:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8ANu-0007FY-88 for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 19:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8ANt-0004it-Uq for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 19:24:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8ANt-0002UO-OI for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 19:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sergey Vinokurov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jan 2022 00:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16421198319545 (code B ref -1); Fri, 14 Jan 2022 00:24:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jan 2022 00:23:51 +0000 Original-Received: from localhost ([127.0.0.1]:34881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8ANi-0002Tt-Kt for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:23:50 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:41774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8ANe-0002Th-Rj for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:23:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8ANe-0006jj-M1 for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 19:23:46 -0500 Original-Received: from [2a00:1450:4864:20::434] (port=33567 helo=mail-wr1-x434.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8ANd-0004hA-5i for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 19:23:46 -0500 Original-Received: by mail-wr1-x434.google.com with SMTP id d19so13119023wrb.0 for ; Thu, 13 Jan 2022 16:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to:from :subject; bh=Eac8/OwYQGHobnX6WiSq/aJtrjmz4yFNIw+ihpNACXI=; b=IvuH+LHCGiBQirnVWmMqa7bdpxd5LbTGNmObu/MWEUCWTDi0H52gMRoS1F0b6+vMS4 eZhcO4ZTbDbLlEZHy9cFCbnHry2OKlXOH5ftwpIIT0giqjstW0Ab1AsjMlIcpehtC/Ye gK4GjObJzeyAWoFbA9Sct8PP8B/TNsC62LGuGE3VVKacLOYMB+0o71jvp2QY7YKxftB9 x/u2vtkDmaMKgkeQxx5vTXHEYB787Rzg9iOfADvTQzXk6VEEIfT601sVvB3n/L3vYUeW zvoLVJ0wczVXEenBNvAniqW2vrel7sT8Xij172paujVvsmupGkRvWY+grp/xIICHv9pP yC0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:from:subject; bh=Eac8/OwYQGHobnX6WiSq/aJtrjmz4yFNIw+ihpNACXI=; b=km3ieo60yZ9M3U/H4KSi5SXBBnaowBJBXAikfgfALFLekQIi4fPunEN8yLwvPKUPGI UncdIvCzNKkeE6uZ+C2ZtwcDJ5MpDg3JCZhhcG2i6/xumsBTJzERl1xzQT0c5zVHSKoC lIpkpSCy2wInvGaneoYfeQrnK5k5r/RZ0jx7KLolAINkoc2MA1LMMFnlMHeTqo9l4TmN YHWGn7WNsJBKJdr5NuaavQklayJ/tc4qpikivIqG4bZBl89wfyO18FO3tAIxz0hYTEW7 NUufEoEcQuBCtnykfPnAB1v8AigyuDMlmj6wWLkUzydFo6Crg4TwwGtg1bpLdRvi0qMx +YKg== X-Gm-Message-State: AOAM533GJIzdcXAo81928bkxIuhJR4tRUPScb9gQwFGbIYx6+kP1nVxF oxQCKgEpn5+9HFeqjovF9EcN4AxOhaE= X-Google-Smtp-Source: ABdhPJydfjVGiFHk6L4mp0aI56JtapKziB5Wu/mkJIXxIj8X7qSG4NderC8fMtjzIFlrhR3umhiFRg== X-Received: by 2002:adf:a59a:: with SMTP id g26mr6080097wrc.262.1642119823431; Thu, 13 Jan 2022 16:23:43 -0800 (PST) Original-Received: from ?IPV6:2a01:4b00:8697:de00:607c:1dff:fe2e:2452? ([2a01:4b00:8697:de00:607c:1dff:fe2e:2452]) by smtp.gmail.com with ESMTPSA id o13sm4726706wrc.111.2022.01.13.16.23.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 16:23:42 -0800 (PST) Content-Language: en-GB X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::434 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=serg.foo@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224147 Archived-At: This is a multi-part message in MIME format. --------------oxcdymuqZIqo6orjfYSjx9Eq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, I've noticed that local_var_alist field of the buffer structure is accessed inconsistently. Sometimes it's Fassoc, sometimes it's Fassq and other times it's assq_no_quit and even an explicit loop. I think it's safe to unify all the accesses via assq_no_quit since it's an internaly maintained alist that definitely has no cycles and elements are cons cells with symbol as their car. Sergey --------------oxcdymuqZIqo6orjfYSjx9Eq Content-Type: text/x-patch; charset=UTF-8; name="0001-Unify-getting-of-values-from-local_var_alist.patch" Content-Disposition: attachment; filename="0001-Unify-getting-of-values-from-local_var_alist.patch" Content-Transfer-Encoding: base64 RnJvbSAyZWQyY2JiOTFkNWUwOTYxNWFkNjYxMDgxMDAxNDE5OGEyNjlkNTM5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnZXkgVmlub2t1cm92IDxzZXJnLmZvb0BnbWFp bC5jb20+CkRhdGU6IEZyaSwgMTQgSmFuIDIwMjIgMDA6MTY6MTkgKzAwMDAKU3ViamVjdDog W1BBVENIXSBVbmlmeSBnZXR0aW5nIG9mIHZhbHVlcyBmcm9tIGxvY2FsX3Zhcl9hbGlzdAoK LS0tCiBzcmMvYnVmZmVyLmMgfCAgMiArLQogc3JjL2RhdGEuYyAgIHwgMTYgKysrKysrLS0t LS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL3NyYy9idWZmZXIuYyBiL3NyYy9idWZmZXIuYwppbmRleCAx MGFjOTE5MTVjLi5hMzA5MTAxNWQ5IDEwMDY0NAotLS0gYS9zcmMvYnVmZmVyLmMKKysrIGIv c3JjL2J1ZmZlci5jCkBAIC0xMjQ3LDcgKzEyNDcsNyBAQCBidWZmZXJfbG9jYWxfdmFsdWUg KExpc3BfT2JqZWN0IHZhcmlhYmxlLCBMaXNwX09iamVjdCBidWZmZXIpCiAgICAgICB7IC8q IExvb2sgaW4gbG9jYWxfdmFyX2FsaXN0LiAgKi8KIAlzdHJ1Y3QgTGlzcF9CdWZmZXJfTG9j YWxfVmFsdWUgKmJsdiA9IFNZTUJPTF9CTFYgKHN5bSk7CiAJWFNFVFNZTUJPTCAodmFyaWFi bGUsIHN5bSk7IC8qIFVwZGF0ZSBJbiBjYXNlIG9mIGFsaWFzaW5nLiAgKi8KLQlyZXN1bHQg PSBGYXNzb2MgKHZhcmlhYmxlLCBCVkFSIChidWYsIGxvY2FsX3Zhcl9hbGlzdCksIFFuaWwp OworCXJlc3VsdCA9IGFzc3Ffbm9fcXVpdCAodmFyaWFibGUsIEJWQVIgKGJ1ZiwgbG9jYWxf dmFyX2FsaXN0KSk7CiAJaWYgKCFOSUxQIChyZXN1bHQpKQogCSAgewogCSAgICBpZiAoYmx2 LT5md2QuZndkcHRyKQpkaWZmIC0tZ2l0IGEvc3JjL2RhdGEuYyBiL3NyYy9kYXRhLmMKaW5k ZXggNWQwNzkwNjkyYi4uZjI4N2MzOGZjZCAxMDA2NDQKLS0tIGEvc3JjL2RhdGEuYworKysg Yi9zcmMvZGF0YS5jCkBAIC0yMTAzLDcgKzIxMDMsNyBAQCBERUZVTiAoIm1ha2UtbG9jYWwt dmFyaWFibGUiLCBGbWFrZV9sb2NhbF92YXJpYWJsZSwgU21ha2VfbG9jYWxfdmFyaWFibGUs CiAKICAgLyogTWFrZSBzdXJlIHRoaXMgYnVmZmVyIGhhcyBpdHMgb3duIHZhbHVlIG9mIHN5 bWJvbC4gICovCiAgIFhTRVRTWU1CT0wgKHZhcmlhYmxlLCBzeW0pOwkvKiBVcGRhdGUgaW4g Y2FzZSBvZiBhbGlhc2luZy4gICovCi0gIHRlbSA9IEZhc3NxICh2YXJpYWJsZSwgQlZBUiAo Y3VycmVudF9idWZmZXIsIGxvY2FsX3Zhcl9hbGlzdCkpOworICB0ZW0gPSBhc3NxX25vX3F1 aXQgKHZhcmlhYmxlLCBCVkFSIChjdXJyZW50X2J1ZmZlciwgbG9jYWxfdmFyX2FsaXN0KSk7 CiAgIGlmIChOSUxQICh0ZW0pKQogICAgIHsKICAgICAgIGlmIChsZXRfc2hhZG93c19idWZm ZXJfYmluZGluZ19wIChzeW0pKQpAQCAtMjE4Myw3ICsyMTgzLDcgQEAgREVGVU4gKCJraWxs LWxvY2FsLXZhcmlhYmxlIiwgRmtpbGxfbG9jYWxfdmFyaWFibGUsIFNraWxsX2xvY2FsX3Zh cmlhYmxlLAogCiAgIC8qIEdldCByaWQgb2YgdGhpcyBidWZmZXIncyBhbGlzdCBlbGVtZW50 LCBpZiBhbnkuICAqLwogICBYU0VUU1lNQk9MICh2YXJpYWJsZSwgc3ltKTsJLyogUHJvcGFn YXRlIHZhcmlhYmxlIGluZGlyZWN0aW9uLiAgKi8KLSAgdGVtID0gRmFzc3EgKHZhcmlhYmxl LCBCVkFSIChjdXJyZW50X2J1ZmZlciwgbG9jYWxfdmFyX2FsaXN0KSk7CisgIHRlbSA9IGFz c3Ffbm9fcXVpdCAodmFyaWFibGUsIEJWQVIgKGN1cnJlbnRfYnVmZmVyLCBsb2NhbF92YXJf YWxpc3QpKTsKICAgaWYgKCFOSUxQICh0ZW0pKQogICAgIGJzZXRfbG9jYWxfdmFyX2FsaXN0 CiAgICAgICAoY3VycmVudF9idWZmZXIsCkBAIC0yMjI0LDcgKzIyMjQsNyBAQCBERUZVTiAo ImxvY2FsLXZhcmlhYmxlLXAiLCBGbG9jYWxfdmFyaWFibGVfcCwgU2xvY2FsX3ZhcmlhYmxl X3AsCiAgICAgY2FzZSBTWU1CT0xfUExBSU5WQUw6IHJldHVybiBRbmlsOwogICAgIGNhc2Ug U1lNQk9MX0xPQ0FMSVpFRDoKICAgICAgIHsKLQlMaXNwX09iamVjdCB0YWlsLCBlbHQsIHRt cDsKKwlMaXNwX09iamVjdCB0bXA7CiAJc3RydWN0IExpc3BfQnVmZmVyX0xvY2FsX1ZhbHVl ICpibHYgPSBTWU1CT0xfQkxWIChzeW0pOwogCVhTRVRCVUZGRVIgKHRtcCwgYnVmKTsKIAlY U0VUU1lNQk9MICh2YXJpYWJsZSwgc3ltKTsgLyogVXBkYXRlIGluIGNhc2Ugb2YgYWxpYXNp bmcuICAqLwpAQCAtMjIzMiwxMyArMjIzMiw5IEBAIERFRlVOICgibG9jYWwtdmFyaWFibGUt cCIsIEZsb2NhbF92YXJpYWJsZV9wLCBTbG9jYWxfdmFyaWFibGVfcCwKIAlpZiAoRVEgKGJs di0+d2hlcmUsIHRtcCkpIC8qIFRoZSBiaW5kaW5nIGlzIGFscmVhZHkgbG9hZGVkLiAgKi8K IAkgIHJldHVybiBibHZfZm91bmQgKGJsdikgPyBRdCA6IFFuaWw7CiAJZWxzZQotCSAgZm9y ICh0YWlsID0gQlZBUiAoYnVmLCBsb2NhbF92YXJfYWxpc3QpOyBDT05TUCAodGFpbCk7IHRh aWwgPSBYQ0RSICh0YWlsKSkKLQkgICAgewotCSAgICAgIGVsdCA9IFhDQVIgKHRhaWwpOwot CSAgICAgIGlmIChFUSAodmFyaWFibGUsIFhDQVIgKGVsdCkpKQotCQlyZXR1cm4gUXQ7Ci0J ICAgIH0KLQlyZXR1cm4gUW5pbDsKKwkgIHJldHVybiBOSUxQIChhc3NxX25vX3F1aXQgKHZh cmlhYmxlLCBCVkFSIChidWYsIGxvY2FsX3Zhcl9hbGlzdCkpKQorCSAgICA/IFFuaWwKKwkg ICAgOiBRdDsKICAgICAgIH0KICAgICBjYXNlIFNZTUJPTF9GT1JXQVJERUQ6CiAgICAgICB7 Ci0tIAoyLjM0LjEKCg== --------------oxcdymuqZIqo6orjfYSjx9Eq--