From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#13448: Cannot build Emacs 24.2.92 Date: Tue, 15 Jan 2013 13:30:21 -0800 Message-ID: <50F5CA6D.8040901@cs.ucla.edu> References: <20130115175931.59dbde1f13cce8bd98fbd08b@gmail.com> <7phamib6y2.fsf@fencepost.gnu.org> <50F5BEBA.2070802@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1358285440 7013 80.91.229.3 (15 Jan 2013 21:30:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Jan 2013 21:30:40 +0000 (UTC) Cc: Andreas Schwab , 13448-done@debbugs.gnu.org To: Xue Fuqiao Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 15 22:30:57 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TvE5s-00019y-Nx for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Jan 2013 22:30:52 +0100 Original-Received: from localhost ([::1]:37148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvE5c-0001Ec-Cw for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Jan 2013 16:30:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvE5Z-0001EM-4B for bug-gnu-emacs@gnu.org; Tue, 15 Jan 2013 16:30:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvE5X-0000yt-RS for bug-gnu-emacs@gnu.org; Tue, 15 Jan 2013 16:30:33 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvE5X-0000ym-O0 for bug-gnu-emacs@gnu.org; Tue, 15 Jan 2013 16:30:31 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TvE62-0001EQ-7X for bug-gnu-emacs@gnu.org; Tue, 15 Jan 2013 16:31:02 -0500 Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Jan 2013 21:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 13448 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 13448@debbugs.gnu.org, eggert@cs.ucla.edu, xfq.free@gmail.com Original-Received: via spool by 13448-done@debbugs.gnu.org id=D13448.13582854584723 (code D ref 13448); Tue, 15 Jan 2013 21:31:01 +0000 Original-Received: (at 13448-done) by debbugs.gnu.org; 15 Jan 2013 21:30:58 +0000 Original-Received: from localhost ([127.0.0.1]:33893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvE5y-0001E8-FW for submit@debbugs.gnu.org; Tue, 15 Jan 2013 16:30:58 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:53232) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvE5v-0001Dy-3D for 13448-done@debbugs.gnu.org; Tue, 15 Jan 2013 16:30:57 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id CAF8339E8105; Tue, 15 Jan 2013 13:30:22 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RGBtSEh+2QjD; Tue, 15 Jan 2013 13:30:22 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 1459039E8008; Tue, 15 Jan 2013 13:30:22 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 In-Reply-To: <50F5BEBA.2070802@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69832 Archived-At: Enabling link time optimization is a common enough need and there's a simple fix that I think makes Emacs a bit clearer, so I pushed the following patch to the trunk as bzr 111533 and I'm marking this as done. The original problem feels like it might be a GCC problem -- GCC shouldn't be dumber (and presumably generate worse code) merely because link-time optimization is enabled. Do you have the time to file a GCC bug report? === modified file 'lib-src/ChangeLog' --- lib-src/ChangeLog 2013-01-02 16:13:04 +0000 +++ lib-src/ChangeLog 2013-01-15 21:24:53 +0000 @@ -1,3 +1,9 @@ +2013-01-15 Paul Eggert + + * make-docfile.c (write_globals): Make it a bit clearer (Bug#13448). + This pacifies GCC 4.7.2 when Emacs is configured with + --enable-link-time-optimization and --enable-gcc-warnings. + 2013-01-01 Juanma Barranquero * makefile.w32-in (lisp1): Add macroexp.elc (bug#13320). === modified file 'lib-src/make-docfile.c' --- lib-src/make-docfile.c 2013-01-01 09:11:05 +0000 +++ lib-src/make-docfile.c 2013-01-15 21:23:34 +0000 @@ -624,7 +624,7 @@ qsort (globals, num_globals, sizeof (struct global), compare_globals); for (i = 0; i < num_globals; ++i) { - char const *type; + char const *type = 0; switch (globals[i].type) { @@ -649,7 +649,7 @@ fatal ("not a recognized DEFVAR_", 0); } - if (globals[i].type != FUNCTION) + if (type) { fprintf (outfile, " %s f_%s;\n", type, globals[i].name); fprintf (outfile, "#define %s globals.f_%s\n",