From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#13448: Cannot build Emacs 24.2.92 Date: Tue, 15 Jan 2013 12:40:26 -0800 Message-ID: <50F5BEBA.2070802__20870.5525416464$1358282515$gmane$org@cs.ucla.edu> References: <20130115175931.59dbde1f13cce8bd98fbd08b@gmail.com> <7phamib6y2.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1358282497 4746 80.91.229.3 (15 Jan 2013 20:41:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Jan 2013 20:41:37 +0000 (UTC) Cc: Xue Fuqiao , Andreas Schwab , Gnulib Bugs , 13448@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 15 21:41:53 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TvDKR-0005PS-Ne for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Jan 2013 21:41:51 +0100 Original-Received: from localhost ([::1]:55233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvDKB-0007kl-ED for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Jan 2013 15:41:35 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvDK8-0007kV-Hh for bug-gnu-emacs@gnu.org; Tue, 15 Jan 2013 15:41:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvDK7-0002ok-KP for bug-gnu-emacs@gnu.org; Tue, 15 Jan 2013 15:41:32 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvDK7-0002oZ-Ab for bug-gnu-emacs@gnu.org; Tue, 15 Jan 2013 15:41:31 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TvDKb-0008Uu-W4 for bug-gnu-emacs@gnu.org; Tue, 15 Jan 2013 15:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Jan 2013 20:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13448 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13448-submit@debbugs.gnu.org id=B13448.135828246632589 (code B ref 13448); Tue, 15 Jan 2013 20:42:01 +0000 Original-Received: (at 13448) by debbugs.gnu.org; 15 Jan 2013 20:41:06 +0000 Original-Received: from localhost ([127.0.0.1]:33846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvDJh-0008TZ-ET for submit@debbugs.gnu.org; Tue, 15 Jan 2013 15:41:06 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:50306) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvDJd-0008T9-Fl for 13448@debbugs.gnu.org; Tue, 15 Jan 2013 15:41:03 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 7511EA60001; Tue, 15 Jan 2013 12:40:29 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TLNRGgmLX2QO; Tue, 15 Jan 2013 12:40:27 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4F2A439E8100; Tue, 15 Jan 2013 12:40:27 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69829 Archived-At: On 01/15/13 11:36, Glenn Morris wrote: > So why does configure.ac contain this: > > gl_WARN_ADD([-Werror], [WERROR_CFLAGS]) That part of the Gnulib manual was out of date. I pushed the following fix to the Gnulib manual. --- ChangeLog | 7 +++++++ doc/warnings.texi | 15 +++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 79defc9..1cdc89f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2013-01-15 Paul Eggert + + doc: clarify -Werror + * doc/warnings.texi (warnings): -Werror is not always a bad idea; + clarify that it's intended for developers, not for ordinary builds, + and mention --enable-gcc-warnings as one possible use. + 2013-01-15 Andoni Morales Alastruey (tiny change) stdint: fix build with Android's Bionic fox x86 diff --git a/doc/warnings.texi b/doc/warnings.texi index 40dfc20..1836c04 100644 --- a/doc/warnings.texi +++ b/doc/warnings.texi @@ -21,10 +21,15 @@ from gnulib), it is useful to apply different warning options to different directories. @item -It allows to use @samp{-Werror} at @samp{make distcheck} time, to verify +It lets you use @samp{-Werror} at @samp{make distcheck} time, to verify that on the maintainer's system, no warnings remain. (Note that use of @samp{-Werror} in @code{CFLAGS} does not work in general, because it may break autoconfiguration.) + +@item +Similarly, it lets you use @samp{-Werror} when the builder runs +@command{configure} with an option such as +@option{--enable-gcc-warnings}. @end itemize To use this module, you need the following: @@ -49,10 +54,12 @@ and before @code{CFLAGS} in build rules emitted by Automake. This allows the user to provide @code{CFLAGS} that override the @code{WARN_CFLAGS}. @end enumerate -Note that it is a bad idea to use @samp{gl_WARN_ADD([-Werror])}. The +@samp{gl_WARN_ADD([-Werror])} is intended for developers, and should be +avoided in contexts where it would affect ordinary installation builds. The warnings emitted by GCC depend, to some extent, on the contents of the system header files, on the size and signedness of built-in types, etc. Use of @samp{-Werror} would cause frustration to all users on platforms that the maintainer has not tested before the release. It is better if -maintainers use @samp{-Werror} only for themselves (for example, during -@samp{make distcheck}, as mentioned above). +@samp{-Werror} is off by default, and is enabled only by developers. +For example, @samp{-Werror} could affect @samp{make distcheck} or +@samp{configure --enable-gcc-warnings} as mentioned above. -- 1.7.11.7