unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Shigeru Fukaya <shigeru.fukaya@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 18767@debbugs.gnu.org
Subject: bug#18767: 24.4; incorrect byte-compile on arithmatic comparisons
Date: Wed, 22 Oct 2014 18:16:42 +0900	[thread overview]
Message-ID: <50CFEDD8E4FAF2shigeru.fukaya@gmail.com> (raw)
In-Reply-To: <jwvoat65sk0.fsf-monnier+emacsbugs@gnu.org>

I think your change of reversion will cause byte-compile error when
more than two args are specified.
Maybe you had better call byte-compile-normal-call for that case at least.

>loop over all args, doing "byte-compile-form" + "dup", and then apply
>the comparisons backward, combining them with "and".

Alternative is,

If non-first args are all constants or simple reference, fold them with AND,
otherwise call them at once by byte-compile-normal-call.


Shigeru


>Version:24.5
>
>> byte-compile of arithmatic comparison operators on more than two
>> arguments is incorrect.
>
>Indeed, I was not very awake when I committed that code.  I just
>reverted the change so the byte-compiler simply doesn't optimize this case.
>To do any better, I think we'll have to do something like:
>
>loop over all args, doing "byte-compile-form" + "dup", and then apply
>the comparisons backward, combining them with "and".
>
>
>        Stefan





  reply	other threads:[~2014-10-22  9:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-18 19:58 bug#18767: 24.4; incorrect byte-compile on arithmatic comparisons Shigeru Fukaya
     [not found] ` <handler.18767.B.141366235315401.ack@debbugs.gnu.org>
2014-10-19 10:20   ` bug#18767: Acknowledgement (24.4; incorrect byte-compile on arithmatic comparisons) Shigeru Fukaya
2014-10-20 21:42 ` bug#18767: 24.4; incorrect byte-compile on arithmatic comparisons Stefan Monnier
2014-10-22  9:16   ` Shigeru Fukaya [this message]
2014-10-22 13:39     ` Stefan Monnier
2014-10-22 16:26       ` Shigeru Fukaya
2014-10-22 17:39         ` Stefan Monnier
2014-10-22 17:58       ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CFEDD8E4FAF2shigeru.fukaya@gmail.com \
    --to=shigeru.fukaya@gmail.com \
    --cc=18767@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).