From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 13154@debbugs.gnu.org
Subject: bug#13154: 24.3.50; emacs_backtrace.txt (different one)
Date: Fri, 14 Dec 2012 11:26:41 +0100 [thread overview]
Message-ID: <50CAFEE1.2080401@gmx.at> (raw)
In-Reply-To: <838v91nkgn.fsf@gnu.org>
>> FWIW, it's not clear to me that `w-o-t-t-b' inside `s-e' is "evil". It might be
>> ineffectual in some contexts, in the sense that it might not do what some users
>> mistakenly might expect, but - for my own understanding - just why do you
>> consider it evil?
>
> Martin will probably tell,
It's evil because `with-output-to-temp-buffer' may pop up a new frame
while `save-window-excursion' gives you the false impression that it can
cope with that situation.
> but in any case I don't think this is
> related to the abort we are discussing.
It should be unrelated.
>> * I found an occurrence in my version of `describe-function', which is based on
>> the vanilla Emacs 22 version in this respect. It has to work for 22+, and 22
>> does not have macro `with-help-window'. (Yes, I could duplicate the code and
>> have a version for Emacs 23+...) In my own help commands (`describe-file',
>> `describe-keymap'), I do not use `save-excursion.
>>
>> * I found one other occurrence of `with-output-to-temp-buffer' inside
>> `save-excursion', but that code is used only when running Emacs 22, and it is a
>> copy of the vanilla Emacs 22 code (for `describe-text-properties'). IOW, the
>> fault is with vanilla Emacs in this case, and this case cannot be manifested in
>> Emacs 24 anyway.
`save-window-excursion' and not `save-excursion', I presume.
> We are looking for Lisp code that would show calls to some primitives,
> wherein we could look for potential bugs on the C level. Does the
> body of Lisp code inside save-excursion in the first occurrence call
> any primitives, or any functions at all? If so, can you show that
> body?
I still don't know whether you are sure that Drew runs some code within
`window-configuration-change-hook'.
martin
next prev parent reply other threads:[~2012-12-14 10:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 5:04 bug#13154: 24.3.50; emacs_backtrace.txt (different one) Drew Adams
2012-12-12 16:54 ` Eli Zaretskii
2012-12-12 17:06 ` Drew Adams
2012-12-12 18:52 ` Eli Zaretskii
2012-12-13 10:29 ` martin rudalics
2012-12-13 17:08 ` Eli Zaretskii
2012-12-13 21:16 ` Drew Adams
2012-12-14 7:47 ` Eli Zaretskii
2012-12-14 10:26 ` martin rudalics [this message]
2012-12-14 15:51 ` Drew Adams
2012-12-14 16:13 ` martin rudalics
2012-12-14 16:18 ` Drew Adams
2012-12-14 16:35 ` martin rudalics
2012-12-14 16:46 ` Drew Adams
2013-02-23 1:13 ` Glenn Morris
2014-02-10 4:36 ` Lars Ingebrigtsen
2012-12-14 15:25 ` Drew Adams
2012-12-14 16:13 ` martin rudalics
2012-12-14 16:18 ` Drew Adams
2012-12-14 10:24 ` martin rudalics
2012-12-14 15:27 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CAFEE1.2080401@gmx.at \
--to=rudalics@gmx.at \
--cc=13154@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).