From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Fri, 14 Dec 2012 11:26:04 +0100 Message-ID: <50CAFEBC.6000208@gmx.at> References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1355480832 16604 80.91.229.3 (14 Dec 2012 10:27:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2012 10:27:12 +0000 (UTC) Cc: Leo , 13152@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 14 11:27:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TjSUG-0000MZ-AU for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2012 11:27:24 +0100 Original-Received: from localhost ([::1]:44956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjSU3-00045p-AS for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2012 05:27:11 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjSTz-00044c-4f for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 05:27:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjSTx-000722-Kx for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 05:27:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjSTx-00071y-He for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 05:27:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TjSUs-0004nj-FV for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 05:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Dec 2012 10:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13152 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13152-submit@debbugs.gnu.org id=B13152.135548083218375 (code B ref 13152); Fri, 14 Dec 2012 10:28:02 +0000 Original-Received: (at 13152) by debbugs.gnu.org; 14 Dec 2012 10:27:12 +0000 Original-Received: from localhost ([127.0.0.1]:41932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSU4-0004mK-GA for submit@debbugs.gnu.org; Fri, 14 Dec 2012 05:27:12 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:55820) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSU1-0004mB-QV for 13152@debbugs.gnu.org; Fri, 14 Dec 2012 05:27:10 -0500 Original-Received: from mailout-de.gmx.net ([10.1.76.27]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0LnVZY-1TCq9C08lS-00heCx for <13152@debbugs.gnu.org>; Fri, 14 Dec 2012 11:26:12 +0100 Original-Received: (qmail invoked by alias); 14 Dec 2012 10:26:11 -0000 Original-Received: from 62-47-53-23.adsl.highway.telekom.at (EHLO [62.47.53.23]) [62.47.53.23] by mail.gmx.net (mp027) with SMTP; 14 Dec 2012 11:26:11 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/YFgdevnvYvosPIQwLj1STEFXrKlIal+/mw6+Qsx ay95FigxdyXerl In-Reply-To: <87obhxbgdw.fsf@mail.jurta.org> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68504 Archived-At: > The doubt raises the fact that evaluating the expression after > selecting " *Marked Files*" was intentionally coded this way > in `dired-mark-pop-up': > > (with-selected-window window > (unwind-protect > (apply function args) > (when (window-live-p window) > (quit-restore-window window 'kill)))) > > I guess the reason was to allow quit-restore-window to kill the > " *Marked Files*" buffer after the minibuffer (that reads a command) > is displayed and exited in `(apply function args)'. I suppose we can safely do #'(lambda (window _value) (unwind-protect (apply function args) (with-selected-window window (when (window-live-p window) (quit-restore-window window 'kill))))) instead if people think it's better. But FUNCTION "should not manipulate files, just read input \(an argument or confirmation)." so I don't see why this matters. martin