From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@jurta.org>
Cc: Leo <sdl.web@gmail.com>, 13152@debbugs.gnu.org
Subject: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed
Date: Fri, 14 Dec 2012 11:26:04 +0100 [thread overview]
Message-ID: <50CAFEBC.6000208@gmx.at> (raw)
In-Reply-To: <87obhxbgdw.fsf@mail.jurta.org>
> The doubt raises the fact that evaluating the expression after
> selecting " *Marked Files*" was intentionally coded this way
> in `dired-mark-pop-up':
>
> (with-selected-window window
> (unwind-protect
> (apply function args)
> (when (window-live-p window)
> (quit-restore-window window 'kill))))
>
> I guess the reason was to allow quit-restore-window to kill the
> " *Marked Files*" buffer after the minibuffer (that reads a command)
> is displayed and exited in `(apply function args)'.
I suppose we can safely do
#'(lambda (window _value)
(unwind-protect
(apply function args)
(with-selected-window window
(when (window-live-p window)
(quit-restore-window window 'kill)))))
instead if people think it's better. But FUNCTION "should not
manipulate files, just read input \(an argument or confirmation)." so I
don't see why this matters.
martin
next prev parent reply other threads:[~2012-12-14 10:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 2:23 bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Leo
2012-12-12 2:47 ` Glenn Morris
2012-12-12 5:30 ` Leo
2012-12-12 8:13 ` Glenn Morris
2012-12-12 9:29 ` Juri Linkov
2012-12-12 11:32 ` Leo
2012-12-12 23:11 ` Juri Linkov
2012-12-13 1:20 ` Leo
2012-12-14 0:46 ` Juri Linkov
2012-12-14 3:05 ` Leo
2012-12-14 10:26 ` martin rudalics
2012-12-14 10:43 ` Leo
2012-12-14 10:58 ` martin rudalics
2012-12-14 10:26 ` martin rudalics [this message]
2012-12-15 10:59 ` Juri Linkov
2013-01-04 3:49 ` Leo Liu
2013-01-04 3:46 ` Leo Liu
2013-01-04 7:08 ` martin rudalics
2013-01-07 2:38 ` Leo Liu
2013-01-07 7:43 ` martin rudalics
2013-01-08 11:02 ` Leo Liu
2013-01-08 22:27 ` Glenn Morris
2013-01-08 22:35 ` Glenn Morris
2013-01-09 1:15 ` Leo Liu
2013-01-09 11:07 ` Leo Liu
2013-01-10 0:50 ` Juri Linkov
2013-01-10 1:04 ` Leo Liu
2013-01-18 18:40 ` Leo Liu
2013-01-09 1:19 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CAFEBC.6000208@gmx.at \
--to=rudalics@gmx.at \
--cc=13152@debbugs.gnu.org \
--cc=juri@jurta.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).