From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#13125: Fix permissions bugs with setgid directories etc. Date: Sun, 09 Dec 2012 00:56:48 -0800 Organization: UCLA Computer Science Department Message-ID: <50C45250.4000809@cs.ucla.edu> References: <50C3E5CE.2000307@cs.ucla.edu> <87vccbeicf.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1355043465 15774 80.91.229.3 (9 Dec 2012 08:57:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 9 Dec 2012 08:57:45 +0000 (UTC) Cc: 13125@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 09 09:57:55 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Thchp-00032h-GW for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Dec 2012 09:57:49 +0100 Original-Received: from localhost ([::1]:57276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Thchd-0004bZ-47 for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Dec 2012 03:57:37 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Thcha-0004bJ-I5 for bug-gnu-emacs@gnu.org; Sun, 09 Dec 2012 03:57:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThchZ-0000w4-II for bug-gnu-emacs@gnu.org; Sun, 09 Dec 2012 03:57:34 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThchZ-0000w0-F1 for bug-gnu-emacs@gnu.org; Sun, 09 Dec 2012 03:57:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Thci1-0002il-Ie for bug-gnu-emacs@gnu.org; Sun, 09 Dec 2012 03:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Dec 2012 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13125 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch security Original-Received: via spool by 13125-submit@debbugs.gnu.org id=B13125.135504343110400 (code B ref 13125); Sun, 09 Dec 2012 08:58:01 +0000 Original-Received: (at 13125) by debbugs.gnu.org; 9 Dec 2012 08:57:11 +0000 Original-Received: from localhost ([127.0.0.1]:33573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThchC-0002hg-MS for submit@debbugs.gnu.org; Sun, 09 Dec 2012 03:57:11 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:45172) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThchA-0002hX-F5 for 13125@debbugs.gnu.org; Sun, 09 Dec 2012 03:57:09 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 2760B39E810A; Sun, 9 Dec 2012 00:56:39 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2PUSvg3rJlLk; Sun, 9 Dec 2012 00:56:38 -0800 (PST) Original-Received: from [192.168.1.3] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id C5BC839E8100; Sun, 9 Dec 2012 00:56:38 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 In-Reply-To: <87vccbeicf.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68226 Archived-At: On 12/09/2012 12:32 AM, Michael Albinus wrote: > the change must be backwards compatible for older > Emacs versions as well as for XEmacs Thanks for mentioning that. The following further patch should suffice: === modified file 'lisp/net/tramp-sh.el' --- lisp/net/tramp-sh.el 2012-12-09 00:50:02 +0000 +++ lisp/net/tramp-sh.el 2012-12-09 08:53:55 +0000 @@ -5024,8 +5024,8 @@ (if (equal id-format 'integer) (user-uid) (user-login-name))) (defun tramp-get-local-gid (id-format) - (if (equal id-format 'integer) - (group-gid) + (if (and (fboundp 'group-gid) (equal id-format 'integer)) + (tramp-compat-funcall 'group-gid) (nth 3 (tramp-compat-file-attributes "~/" id-format)))) ;; Some predefined connection properties.