From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#12854: 24.2.50; `display-buffer-alist': conditions are not handled as documented Date: Tue, 13 Nov 2012 14:50:46 +0100 Message-ID: <50A25036.8070008@gmx.at> References: <87a9upp8qb.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1352814701 12276 80.91.229.3 (13 Nov 2012 13:51:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2012 13:51:41 +0000 (UTC) Cc: 12854@debbugs.gnu.org To: michael_heerdegen@web.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 13 14:51:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TYGu7-0005EL-2p for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Nov 2012 14:51:51 +0100 Original-Received: from localhost ([::1]:45076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYGtx-0006JF-FQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Nov 2012 08:51:41 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYGts-0006Hr-3v for bug-gnu-emacs@gnu.org; Tue, 13 Nov 2012 08:51:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYGtp-0003ec-1u for bug-gnu-emacs@gnu.org; Tue, 13 Nov 2012 08:51:36 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYGto-0003eY-Ul for bug-gnu-emacs@gnu.org; Tue, 13 Nov 2012 08:51:32 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TYGuI-0006GR-9q for bug-gnu-emacs@gnu.org; Tue, 13 Nov 2012 08:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Nov 2012 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12854-submit@debbugs.gnu.org id=B12854.135281469824040 (code B ref 12854); Tue, 13 Nov 2012 13:52:02 +0000 Original-Received: (at 12854) by debbugs.gnu.org; 13 Nov 2012 13:51:38 +0000 Original-Received: from localhost ([127.0.0.1]:37964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYGtt-0006Fh-Gq for submit@debbugs.gnu.org; Tue, 13 Nov 2012 08:51:37 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:39115) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1TYGtq-0006FX-Dh for 12854@debbugs.gnu.org; Tue, 13 Nov 2012 08:51:35 -0500 Original-Received: (qmail invoked by alias); 13 Nov 2012 13:50:48 -0000 Original-Received: from 62-47-46-229.adsl.highway.telekom.at (EHLO [62.47.46.229]) [62.47.46.229] by mail.gmx.net (mp041) with SMTP; 13 Nov 2012 14:50:48 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18HgNhNd/8HCIPWqYOIly7rMiztT6POag7f3AnQpD vX8KABRtyoSy63 In-Reply-To: <87a9upp8qb.fsf@web.de> X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: 0.8 (/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66866 Archived-At: > (defun display-buffer-assq-regexp (buffer-name alist) > "Retrieve ALIST entry corresponding to BUFFER-NAME." > (catch 'match > (dolist (entry alist) > (let ((key (car entry))) > (when (or (and (stringp key) > (string-match-p key buffer-name)) > (and (symbolp key) (functionp key) > (funcall key buffer-name alist))) > (throw 'match (cdr entry))))))) > > > Obviously, two things are wrong here: > > (1) If CONDITION is a function, it currently must be a symbol. I don't > see why lambda expressions should be forbidden. The user should not > need to use defun only to be able specify an argument. I see no problems with removing the (symbolp key) check. > (2) If CONDITION is a function, it takes _two_ arguments: a buffer > _name_ (not a buffer) _and_ an alist. That should be clarified in the > docstring. IIUC the correct solution is to not pass ALIST to the function specified by `key'. martin