From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#50005: 28.0.50; silence a couple byte-compiler warnings in ERC Date: Thu, 12 Aug 2021 10:15:45 +0200 Message-ID: <50A0B8E0-2F07-4AAC-8170-27990F9FEAD4@acm.org> References: <87v94cjd89.fsf@neverwas.me> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36897"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50005@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 12 10:16:43 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mE5tK-0009N8-Js for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 10:16:42 +0200 Original-Received: from localhost ([::1]:56062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mE5tJ-00089X-DR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 04:16:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mE5sh-0007Km-5X for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 04:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mE5sg-0007ZD-V3 for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 04:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mE5sg-0007wx-Eg for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 04:16:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v94cjd89.fsf@neverwas.me> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Aug 2021 08:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50005 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50005-submit@debbugs.gnu.org id=B50005.162875615830532 (code B ref 50005); Thu, 12 Aug 2021 08:16:02 +0000 Original-Received: (at 50005) by debbugs.gnu.org; 12 Aug 2021 08:15:58 +0000 Original-Received: from localhost ([127.0.0.1]:37435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mE5sc-0007wO-B6 for submit@debbugs.gnu.org; Thu, 12 Aug 2021 04:15:58 -0400 Original-Received: from mail1450c50.megamailservers.eu ([91.136.14.50]:54098 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mE5sZ-0007w7-US for 50005@debbugs.gnu.org; Thu, 12 Aug 2021 04:15:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1628756148; bh=fJB0WAgp3aHlWPVeoyQeCse0iQh9cUd8bEuK0mbmhnM=; h=From:Subject:Date:Cc:To:From; b=F6DXD3P6++zZ3094BWxt88WNzh7IzlH33kmPMWYxyKLEHPJDndgbM9qpCubENeGqF Z3XYF2grDmsxAOO+gYRS2Zb2/LZCe1/+CFB9ZCJrEU2qCltbBkIcUh0Rdb8XGshA2G VDdi28c8rY2WbtzyogBJKA+58cQxVQ+0bzEBm0cc= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17C8FkUi000588; Thu, 12 Aug 2021 08:15:48 +0000 X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F27.6114D8B4.0032, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=K5pc4BeI c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=aWcSrmmd2K7Fbca1LA4A:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211651 Archived-At: > (defcustom erc-lurker-ignore-chars "`_" > "Characters at the end of a nick to strip for activity tracking = purposes. > - > +The usual rules regarding ]^\\ and - in \"character alternatives\ = apply. Oops (two typos), but thanks for illustrating the problems with: > + (string-trim-right nick (concat "[" erc-lurker-ignore-chars = "]+")) Attempting to construct character alternatives by hand is usually a = mistake; it's just too error-prone. Better use rx or regexp-opt instead: (rx-to-string `(+ (in ,@(string-to-list erc-lurker-ignore-chars))) t) or (concat (regexp-opt (mapcar #'char-to-string erc-lurker-ignore-chars)) = "+")