From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50777: Dropping EIEIO from xref (for performance) Date: Sun, 26 Sep 2021 04:15:27 +0300 Message-ID: <508ef22b-02e2-c67b-3e34-be47d22f3328@yandex.ru> References: <6b5b14d5-b2ca-8add-f4bf-a3405270c07a@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5815"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 50777@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 26 03:16:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUIm2-0001LI-Bg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Sep 2021 03:16:10 +0200 Original-Received: from localhost ([::1]:53590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUIm1-0000sO-7j for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 21:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUIlu-0000sF-RD for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 21:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUIlu-00080z-Jl for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 21:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUIlu-00057f-CX for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 21:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Sep 2021 01:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50777 X-GNU-PR-Package: emacs Original-Received: via spool by 50777-submit@debbugs.gnu.org id=B50777.163261893819651 (code B ref 50777); Sun, 26 Sep 2021 01:16:02 +0000 Original-Received: (at 50777) by debbugs.gnu.org; 26 Sep 2021 01:15:38 +0000 Original-Received: from localhost ([127.0.0.1]:35191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIlV-00056t-UZ for submit@debbugs.gnu.org; Sat, 25 Sep 2021 21:15:38 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:35656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIlT-00056h-OV for 50777@debbugs.gnu.org; Sat, 25 Sep 2021 21:15:36 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id i23so39554809wrb.2 for <50777@debbugs.gnu.org>; Sat, 25 Sep 2021 18:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gJMSU/uEMZ7+5EApmZDKZi0fBkIv7F/NGO06rOTGf7E=; b=KKVVc3agYjhjhODfpS9QgeSMOAWLuT1isi7lkSkO3kye35Y9xZTR57wD+NnJPR/knG xqQZpJinwP+YNfX61wfmcNcLb/jIVw8p0QpqP4fqJqze+oqG2FVDeYpMrcAhqH5W2jb4 HUdRSBBKzKTO0p4T/LTT+/pAizabm7jl/oKosQbIOBYkCKl+WZW/MxOUifXnmhPzERHH +pU6JgwZvnVv768OjbXeXCjlVH0K3UOPunygcrlNNHDaLvW+iZgQY8M9b926t+ULJJAX QLdbNYCcTBbZ1CClzcP0vmhfp0K8oCygBhWQk6XIg7Stlu8q7BgwT/JqoXP3OO4ctYzT 479Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gJMSU/uEMZ7+5EApmZDKZi0fBkIv7F/NGO06rOTGf7E=; b=nE53Bnps2RtEGQofdfYPSoR44zwo+rO/zJm/5T8l8FyHnk5zKAbTN3fNhKyULg0Su9 LthJ+UliW5loPZxDzwEeEf0kN0IzjIFl1y8F+iec9M02Mq1l+nOE7MmoMCHYU4TILM6a UgPv30567rZ7gFjUKSdOmq4xxEF0C7aHLl41QeV/RWxNHtaAZlpslVpa8nwRe5bdANhW jZTCaf7l57br3JJSgo47E4Za+zwLwB9KtCbjMcJ+L/WPX93zpij9nN4frdfflRBoE3ik vPSsRdH5LVTOiRCOr3I1Kvs7YY0RcJlIHSaSd9zSLtyjkx3jsfv/84NP9J1zjllBZeBO iUcQ== X-Gm-Message-State: AOAM533fKWCVoFCLY7WJk9V4uXZS4nkeKDE4GP9CuJEAbqB54rOuCEx+ kebYtCo1/zXBsfdaEsVBlGQ= X-Google-Smtp-Source: ABdhPJxAHApminbbIIulgCN5XE68lgWNPHcYLEZXi6I3UIREILXOMD85BFZcaRbJIfy7pfD8E6wUjA== X-Received: by 2002:a5d:6dad:: with SMTP id u13mr19028700wrs.55.1632618930024; Sat, 25 Sep 2021 18:15:30 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n66sm12592271wmn.2.2021.09.25.18.15.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Sep 2021 18:15:29 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215542 Archived-At: On 24.09.2021 18:32, Dmitry Gutov wrote: > One area of bigger concern is whether code compiled against the new > version of Xref would work with the old one without recompiling (and > vice versa). I guess for that to work we need to disable inlining on > xref-item's accessors, at least. Maybe there's something else I'm missing. OK, so I've done some testing with ivy-xref (fixing it to stop using with-slots), and (:noinline t) indeed seems necessary for Emacs using previous version of xref to run code from ivy-xref.elc compiled with the newer version without errors. But since I tested this in Emacs 27, (void-function make-closure) was a much bigger problem. This is apparently how lambdas are compiled now. So this is a +1 minor reason to release the new version together with Emacs 28: less need to worry about :noinline. Though we could use it anyway, to avoid tying byte code to a particular implementation: the performance seems unchanged.