From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12632: file permissions checking mishandled when setuid Date: Mon, 22 Oct 2012 14:30:41 -0700 Message-ID: <5085BB01.2030402@cs.ucla.edu> References: <5078CAB6.7020509@cs.ucla.edu> <83fw5h5yo6.fsf@gnu.org> <507B010F.20105@cs.ucla.edu> <831uh06gqd.fsf@gnu.org> <507B15B0.2040802@cs.ucla.edu> <83txtw4xmk.fsf@gnu.org> <507B2354.3030408@cs.ucla.edu> <83sj9g4vy7.fsf@gnu.org> <507BAA6C.2000601@cs.ucla.edu> <83lif74p78.fsf@gnu.org> <507C823D.40304@cs.ucla.edu> <83d30j3wqg.fsf@gnu.org> <507CF802.6000305@cs.ucla.edu> <83a9vm4bmv.fsf@gnu.org> <50818763.80501@cs.ucla.edu> <83wqymz4me.fsf@gnu.org> <5081A1DF.9000009@cs.ucla.edu> <5081ABD6.9060002@cs.ucla.edu> <23r4osd2f9.fsf@fencepost.gnu.org> <50836366.6080600@cs.ucla.edu> <5084E1B2.2020105@cs.ucla.edu> <83ipa2ctl2.fsf@gnu.org> <5085AD9E.7040701@cs.ucla.edu> <838vaycj65.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1350941480 25666 80.91.229.3 (22 Oct 2012 21:31:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Oct 2012 21:31:20 +0000 (UTC) Cc: 12632@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 22 23:31:28 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQPam-0002su-Qz for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 23:31:24 +0200 Original-Received: from localhost ([::1]:54476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQPaf-0005ya-5Q for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 17:31:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQPac-0005yH-NV for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 17:31:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQPab-0007dL-PI for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 17:31:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQPab-0007dG-Lz for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 17:31:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TQPcL-00070T-RU for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 17:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Oct 2012 21:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 12632-submit@debbugs.gnu.org id=B12632.135094156726913 (code B ref 12632); Mon, 22 Oct 2012 21:33:01 +0000 Original-Received: (at 12632) by debbugs.gnu.org; 22 Oct 2012 21:32:47 +0000 Original-Received: from localhost ([127.0.0.1]:56361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQPc6-000701-AD for submit@debbugs.gnu.org; Mon, 22 Oct 2012 17:32:46 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:47334) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQPc3-0006zo-Nw for 12632@debbugs.gnu.org; Mon, 22 Oct 2012 17:32:45 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 87050A60009; Mon, 22 Oct 2012 14:30:49 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7exEpvBSvm+k; Mon, 22 Oct 2012 14:30:49 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DBC6DA60002; Mon, 22 Oct 2012 14:30:48 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 In-Reply-To: <838vaycj65.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65881 Archived-At: On 10/22/2012 02:04 PM, Eli Zaretskii wrote: > Windows _is_ such a platform, "//foo/bar" and "/foo/bar" are very > different things there. What is the difference, from the point of view of the test? The test is concerned only with trailing separators, not with leading ones, so it shouldn't matter that "//foo/bar" and "/foo/bar" might be different. Is it possible in Windows that the searchability of the file named "//" differs from the searchability of "/"? Or that the searchability of "\/" differs from that of "\"? Could you explain a scenario where that might happen? (By "searchable", I mean that the file is a directory and one can resolve file names within that directory.) Emacs currently assumes that all directories are searchable on Windows, so any such scenario would break Emacs elsewhere, right? If "/" and "//" and "\/" and "\" are always searchable, it shouldn't matter which Emacs tested. > Windows file APIs are picky wrt trailing slashes. Can you give an example of how that might affect the test? It's OK if Windows is picky about trailing slashes -- POSIX platforms are too -- all that matters is whether the pickiness derails the test. > We use IS_DIRECTORY_SEP in other places, so why avoid it here? If it's not needed, it makes the code a bit harder to read.