From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 12600@debbugs.gnu.org
Subject: bug#12600: 24.2.50; linum-mode: line numbers in fringe do not refresh when resizing frame
Date: Tue, 16 Oct 2012 11:39:37 +0200 [thread overview]
Message-ID: <507D2B59.7030008@gmx.at> (raw)
In-Reply-To: <83ipab4j8w.fsf@gnu.org>
>> BTW, I meanwhile discovered that the update_mode_line field (with a
>> misleading comment IIUC) is the canonical approach to ask for
>> redisplaying a specific window.
>
> That's not my reading of the code. The w->update_mode_line flag, if
> non-zero, forces redisplay of the mode line, and also of the menu bar
> and the tool bar, of that window. Where did you see that its effect
> is to redisplay the whole window?
Because the doc-string for Fforce_window_update says "If optional arg
OBJECT is a window, force redisplay of that window only." but the code
does
mark_window_display_accurate (object, 0);
w->update_mode_line = 1;
if (BUFFERP (w->buffer))
XBUFFER (w->buffer)->prevent_redisplay_optimizations_p = 1;
++update_mode_lines;
and does not set windows_or_buffers_changed. So apparently the above
(and not only setting w->update_mode_line to 1 as I concluded
incorrectly) are sufficient to force the redisplay of a single window
(including all windows showing the same buffer).
> force-window-update with a window as its argument just marks that one
> window's display "inaccurate", requests redisplay of its mode-line,
> and prevents optimizations of any other window displaying the same
> buffer. Windows that don't display this buffer can still avoid some
> or all of redisplay through optimizations.
That's the case I had in mind. So if I follow you correctly,
set_window_buffer could instead of doing
windows_or_buffers_changed++;
call Fforce_window_update with the window whose buffer gets set as its
argument.
> I think resizing requests a thorough redisplay anyway,
Resizing a frame almost certainly does. change_frame_size_1 does
adjust_glyphs (f);
calculate_costs (f);
SET_FRAME_GARBAGED (f);
f->resized_p = 1;
but none of these seem useful for Fwindow_end (are they useful anywhere
at all?), so ...
> setting windows_or_buffers_changed cannot hurt.
... I _had to_ set this in order to make the check in Fwindow_end fail.
martin
next prev parent reply other threads:[~2012-10-16 9:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 23:03 bug#12600: 24.2.50; linum-mode: line numbers in fringe do not refresh when resizing frame Christoph Scholtes
2012-10-08 7:31 ` Eli Zaretskii
2012-10-08 9:17 ` martin rudalics
2012-10-08 13:59 ` Stefan Monnier
2012-10-08 15:48 ` Eli Zaretskii
2012-10-09 9:36 ` martin rudalics
2012-10-09 17:04 ` Eli Zaretskii
2012-10-10 10:22 ` martin rudalics
2012-10-10 15:45 ` Eli Zaretskii
2012-10-11 7:12 ` martin rudalics
2012-10-11 16:56 ` Eli Zaretskii
2012-10-12 7:32 ` martin rudalics
2012-10-12 8:52 ` Eli Zaretskii
2012-10-12 9:35 ` martin rudalics
2012-10-12 13:51 ` Eli Zaretskii
2012-10-12 15:42 ` martin rudalics
2012-10-12 14:55 ` Stefan Monnier
2012-10-12 15:36 ` Eli Zaretskii
2012-10-12 15:43 ` martin rudalics
2012-10-13 8:56 ` Eli Zaretskii
2012-10-13 9:51 ` martin rudalics
2012-10-13 12:45 ` Eli Zaretskii
2012-10-13 17:45 ` martin rudalics
2012-10-13 18:08 ` Eli Zaretskii
2012-10-14 10:21 ` martin rudalics
2012-10-14 12:06 ` Eli Zaretskii
2012-10-14 18:33 ` martin rudalics
2012-10-14 20:01 ` Eli Zaretskii
2012-10-15 9:41 ` martin rudalics
2012-10-15 19:39 ` Eli Zaretskii
2012-10-16 9:39 ` martin rudalics [this message]
2012-10-16 17:35 ` Eli Zaretskii
2012-10-15 9:40 ` martin rudalics
2012-11-09 9:49 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507D2B59.7030008@gmx.at \
--to=rudalics@gmx.at \
--cc=12600@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).