From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 12541-done@debbugs.gnu.org
Subject: bug#12541: Prefer plain 'static' to 'static inline'.
Date: Tue, 02 Oct 2012 00:00:54 -0700 [thread overview]
Message-ID: <506A9126.1040406@cs.ucla.edu> (raw)
In-Reply-To: <83fw5yazdz.fsf@gnu.org>
On 10/01/2012 10:14 AM, Eli Zaretskii wrote:
> Perhaps that's because STRING_CHAR could call a function?
Yes, I suspect that's it. When there's enough register pressure it
can sometimes make sense to put a call inside a function rather than
inline it.
> Nevertheless, I'm okay with removing the 'inline' qualifier from
> bidi.c. If the performance hit is significant, I'm sure we will hear
> from users shortly. Otherwise, I'll try to measure the performance
> with and without 'inline' when I have time, and we can take it from
> there.
Thanks, I did that as trunk bzr 110345 and am marking this as done.
For what it's worth, the amount of inlining often depends greatly on
exactly which compiler flags are used -- with GCC, for example, it can
matter quite a bit whether one uses -O1, -O2, or -O3.
prev parent reply other threads:[~2012-10-02 7:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 8:00 bug#12541: Prefer plain 'static' to 'static inline' Paul Eggert
2012-09-30 9:49 ` Eli Zaretskii
2012-09-30 14:18 ` Jason Rumney
2012-09-30 15:57 ` Eli Zaretskii
2012-09-30 17:58 ` Paul Eggert
2012-09-30 18:33 ` Eli Zaretskii
2012-09-30 18:48 ` Paul Eggert
2012-10-01 6:38 ` Paul Eggert
2012-10-01 17:14 ` Eli Zaretskii
2012-10-02 7:00 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506A9126.1040406@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=12541-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).