From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12541: Prefer plain 'static' to 'static inline'. Date: Sun, 30 Sep 2012 11:48:15 -0700 Organization: UCLA Computer Science Department Message-ID: <506893EF.8080604@cs.ucla.edu> References: <5067FC19.3000704@cs.ucla.edu> <83d313et6t.fsf@gnu.org> <50688861.2090306@cs.ucla.edu> <83y5jrcqe7.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1349030925 22825 80.91.229.3 (30 Sep 2012 18:48:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2012 18:48:45 +0000 (UTC) Cc: 12541@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 30 20:48:50 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIOZO-00027h-4w for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2012 20:48:50 +0200 Original-Received: from localhost ([::1]:50034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIOZI-0003iR-Po for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2012 14:48:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIOZG-0003iM-5o for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 14:48:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIOZD-0008KW-Vm for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 14:48:42 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIOZD-0008KS-RS for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 14:48:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TIOZZ-0004rP-KN for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 14:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Sep 2012 18:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12541-submit@debbugs.gnu.org id=B12541.134903092318658 (code B ref 12541); Sun, 30 Sep 2012 18:49:01 +0000 Original-Received: (at 12541) by debbugs.gnu.org; 30 Sep 2012 18:48:43 +0000 Original-Received: from localhost ([127.0.0.1]:34933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIOZG-0004qs-MH for submit@debbugs.gnu.org; Sun, 30 Sep 2012 14:48:43 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:60518) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIOZD-0004qi-5h for 12541@debbugs.gnu.org; Sun, 30 Sep 2012 14:48:40 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 4DB6739E8015; Sun, 30 Sep 2012 11:48:16 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eXBCyG0-dIKY; Sun, 30 Sep 2012 11:48:15 -0700 (PDT) Original-Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 5E3B339E800E; Sun, 30 Sep 2012 11:48:15 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 In-Reply-To: <83y5jrcqe7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65033 Archived-At: On 09/30/2012 11:33 AM, Eli Zaretskii wrote: >> From: Paul Eggert >> >> On my platform (GCC 4.7.2 -O3, x86-64, Fedora 17, trunk bzr 110287) >> GCC does not always inline 'bidi_char_at_pos': in a couple of cases >> the function is only partly inlined. > > Is this so with either 'static inline' or with 'static'? The former. That is, the above comment is talking about the current trunk, which uses 'static inline'. > is there any difference, in terms of generated code, that > you see between using and not using 'inline' for these functions? Yes, as described below, if we omit 'inline' GCC does less inlining: it inlines the small static functions, but some of the larger ones are not inlined. >> With the proposed change, the set of functions that are not always >> inlined expands to bidi_cache_iterator_state, bidi_char_at_pos, and >> bidi_fetch_char, and (if we also include functions that are partially >> inlined) bidi_cache_search and bidi_get_type. > > Were they also not inlined before the change? Most of these functions were inlined before the change. However, as described above, bidi_char_at_pos was only partially inlined before the change.