From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 12541@debbugs.gnu.org
Subject: bug#12541: Prefer plain 'static' to 'static inline'.
Date: Sun, 30 Sep 2012 11:48:15 -0700 [thread overview]
Message-ID: <506893EF.8080604@cs.ucla.edu> (raw)
In-Reply-To: <83y5jrcqe7.fsf@gnu.org>
On 09/30/2012 11:33 AM, Eli Zaretskii wrote:
>> From: Paul Eggert <eggert@cs.ucla.edu>
>>
>> On my platform (GCC 4.7.2 -O3, x86-64, Fedora 17, trunk bzr 110287)
>> GCC does not always inline 'bidi_char_at_pos': in a couple of cases
>> the function is only partly inlined.
>
> Is this so with either 'static inline' or with 'static'?
The former. That is, the above comment is talking about the current
trunk, which uses 'static inline'.
> is there any difference, in terms of generated code, that
> you see between using and not using 'inline' for these functions?
Yes, as described below, if we omit 'inline' GCC does less inlining:
it inlines the small static functions, but some of the larger ones are
not inlined.
>> With the proposed change, the set of functions that are not always
>> inlined expands to bidi_cache_iterator_state, bidi_char_at_pos, and
>> bidi_fetch_char, and (if we also include functions that are partially
>> inlined) bidi_cache_search and bidi_get_type.
>
> Were they also not inlined before the change?
Most of these functions were inlined before the change. However, as
described above, bidi_char_at_pos was only partially inlined before
the change.
next prev parent reply other threads:[~2012-09-30 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 8:00 bug#12541: Prefer plain 'static' to 'static inline' Paul Eggert
2012-09-30 9:49 ` Eli Zaretskii
2012-09-30 14:18 ` Jason Rumney
2012-09-30 15:57 ` Eli Zaretskii
2012-09-30 17:58 ` Paul Eggert
2012-09-30 18:33 ` Eli Zaretskii
2012-09-30 18:48 ` Paul Eggert [this message]
2012-10-01 6:38 ` Paul Eggert
2012-10-01 17:14 ` Eli Zaretskii
2012-10-02 7:00 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506893EF.8080604@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=12541@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).