unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Helmut Eller <eller.helmut@gmail.com>
Cc: 12502@debbugs.gnu.org
Subject: bug#12502: 24.2.50; Debugger messes up current-buffer
Date: Mon, 24 Sep 2012 14:38:01 +0200	[thread overview]
Message-ID: <50605429.10900@gmx.at> (raw)
In-Reply-To: <m2lifzizzr.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

 > The debugger now changes the current buffer in the following situation:
[...]
 > This is a regression to older versions.

Thanks for the report.  Would the attached patch fix it?

BTW, I notice that you quite often run functions with a current buffer
different from that of the selected window.  In all these cases
`quit-window' might misbehave for you because it does not restore the
buffer that was current at the time the window's buffer was displayed.
So if you see any problems in this context, please tell me.  We then
could try to restore the current buffer (optionally at least) too.

martin

[-- Attachment #2: debug-restore-current-buffer.diff --]
[-- Type: text/plain, Size: 678 bytes --]

=== modified file 'lisp/emacs-lisp/debug.el'
--- lisp/emacs-lisp/debug.el	2012-09-20 13:35:13 +0000
+++ lisp/emacs-lisp/debug.el	2012-09-24 12:30:50 +0000
@@ -273,7 +273,8 @@
 	    (setq debugger-previous-window-height
 		  (window-total-size debugger-window))
 	    ;; Unshow debugger-buffer.
-	    (quit-restore-window debugger-window debugger-bury-or-kill))
+	    (quit-restore-window debugger-window debugger-bury-or-kill)
+	    (set-buffer debugger-old-buffer))
           ;; Restore previous state of debugger-buffer in case we were
           ;; in a recursive invocation of the debugger, otherwise just
           ;; erase the buffer and put it into fundamental mode.



  reply	other threads:[~2012-09-24 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  8:31 bug#12502: 24.2.50; Debugger messes up current-buffer Helmut Eller
2012-09-24 12:38 ` martin rudalics [this message]
2012-09-25 15:36   ` Helmut Eller
2012-09-25 16:45     ` martin rudalics
2012-10-03  9:14     ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50605429.10900@gmx.at \
    --to=rudalics@gmx.at \
    --cc=12502@debbugs.gnu.org \
    --cc=eller.helmut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).