From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#12450: Remove configure's --without-sync-input option. Date: Sun, 16 Sep 2012 02:52:35 -0700 Message-ID: <5055A163.2070600@dancol.org> References: <50543449.1070306@cs.ucla.edu> <50554458.6040308@cs.ucla.edu> <83haqysdko.fsf@gnu.org> <50558C80.4080408@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0FAAE1C5767EFEF60847AA20" X-Trace: ger.gmane.org 1347789239 17065 80.91.229.3 (16 Sep 2012 09:53:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Sep 2012 09:53:59 +0000 (UTC) Cc: lekktu@gmail.com, rms@gnu.org, 12450@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 16 11:54:02 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TDBY9-0000ge-Hg for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Sep 2012 11:54:01 +0200 Original-Received: from localhost ([::1]:55275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDBY5-0003QP-KI for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Sep 2012 05:53:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDBY3-0003QK-BS for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2012 05:53:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDBY2-0001Tn-6L for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2012 05:53:55 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDBY2-0001Tj-2p for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2012 05:53:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TDBZ7-0007lE-Hw for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2012 05:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Sep 2012 09:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12450 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12450-submit@debbugs.gnu.org id=B12450.134778924129753 (code B ref 12450); Sun, 16 Sep 2012 09:55:01 +0000 Original-Received: (at 12450) by debbugs.gnu.org; 16 Sep 2012 09:54:01 +0000 Original-Received: from localhost ([127.0.0.1]:36487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDBY9-0007jk-D1 for submit@debbugs.gnu.org; Sun, 16 Sep 2012 05:54:01 -0400 Original-Received: from dancol.org ([96.126.100.184]:51182) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDBY7-0007jZ-55 for 12450@debbugs.gnu.org; Sun, 16 Sep 2012 05:54:00 -0400 Original-Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1TDBWy-0004u5-KW; Sun, 16 Sep 2012 02:52:48 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20120824 Thunderbird/15.0 In-Reply-To: <50558C80.4080408@cs.ucla.edu> X-Enigmail-Version: 1.4.4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64408 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0FAAE1C5767EFEF60847AA20 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 9/16/12 1:23 AM, Paul Eggert wrote: > On 09/15/2012 11:10 PM, Eli Zaretskii wrote: >> I still would like to have BLOCK_INPUT in xmalloc and friends, >> conditioned on some global variable being non-zero. >=20 > There is no need for that, if we've checked our signal handlers to > make sure that they invoke only async-signal-safe functions. >=20 > Conversely, if we don't check our signal handlers, and we > are worried that signal handlers might be buggy and might be > invoking non-async-signal-safe functions, we should put > debugging wrappers around not only malloc and friends: we > should wrap every call to every non-async-signal-safe > function. But there must be hundreds of such functions, and > it's not practical to wrap them all. It's much more practical > to keep signal handlers small and simple, which is what we've > already done. >=20 > Leaving BLOCK_INPUT in xmalloc and friends would be a > revenant of the bad old days when our signal handlers > invoked the Lisp interpreter and ran random code. We're > better off with the standard practice on GNU and POSIXish > systems for the past four years, which is to not do that. > That is why removing those BLOCK_INPUTs has long been on our > TODO list. What this patch is doing, is marking that job as > done, because it effectively has been done for four years on > GNU and POSIXish platforms, and we can do it for MS-Windows > now. >=20 >> That thread left the MS-Windows case indeterminate. >=20 > OK, but at this point we don't know of any real problems > that we'd have by assuming SYNC_INPUT on MS-Windows. > SYNC_INPUT is a much simpler model than non-SYNC_INPUT, > so this is not surprising. The cygw32 port uses SYNC_INPUT on Windows. I've been using it for almost a year in one form or another, and I haven't noticed any problems. There might be a few lurking bugs, however: one thing that stands out is that w32term.c, unlike xterm.c, sets interrupt_input_pending, but doesn't set pending_signals. --------------enig0FAAE1C5767EFEF60847AA20 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlBVoWQACgkQ17c2LVA10VtABgCfbDeeBM5dU5twoziq/e+AQwCg 7LYAn11GBfKl9l1cGypznzOku02nFfoz =9AAu -----END PGP SIGNATURE----- --------------enig0FAAE1C5767EFEF60847AA20--