From: Dmitry Gutov <dgutov@yandex.ru>
To: Jonathan Ganc <jonganc@gmail.com>,
npostavs@users.sourceforge.net, 26066@debbugs.gnu.org,
Stefan Monnier <monnier@IRO.UMontreal.CA>
Subject: bug#26066: 26.0.50; vc-git-status gives wrong result
Date: Tue, 11 Apr 2017 03:07:21 +0300 [thread overview]
Message-ID: <505388da-e642-8c98-35c0-261d09ff13e1@yandex.ru> (raw)
In-Reply-To: <a96a4c5f-1bd6-3756-2189-460d76f44b98@gmail.com>
On 23.03.2017 04:18, Jonathan Ganc wrote:
> Yeah, I'm not really sure what the workflow should be; I'm just getting
> started with the vc functions in emacs. One issue, though, is that
> default-directory can only be set for functions that identify a
> filename, because we need to have a directory to set things to. For this
> reason, I don't know that one could generally set default-directory in
> vc-call-backend.
You are right. But we could set it in vc-state-refresh.
> It could make sense to set default-directory for
> vc-git--run-command-string (although to get vc-git-state to work, one
> would still need to set it for vc-git--empty-db-p).
That's also an option, yes. But binding it on the higher level would be
better, I think.
> It's worth nothing there seems to be inconsistency within vc-git. Some
> commands like vc-git-checkin, vc-git-next-revision, do set
> default-directory to the directory of the input file; other comands like
> vc-git-merge-branch seem to do the opposite and assume the root is
> already given by default-directory.
True. Some of those occurrences are most likely there just so the DIR
argument is not left unused. Some have less obvious reasons.
vc-git-checkin, for instance, does it to call 'git commit' from the
repository root, instead of an arbitrary directory in it. I'm sure it's
really necessary, though.
> At the very least, the documentation for vc-git-state should note that
> default-directory needs to be set.
The backend-specific functions are largely internal, we don't expect
clients to call them directly. If anything, the documentation can be
clarified on whether an arbitrary backend's 'state' command should set
default-directory, or use the current one.
> You're right, in principle, but atom handles it by coloring directories
> based on if they have modified files within. I don't know if there is a
> "canonical" way to do this, although one idea would be to return a list
> of all file status in the directory, e.g. `(up-to-date modified ignored)`.
Yeah, diff-hl-dired does something like that. If all the "interesting"
statuses in a directory are the same, we assign it that status. If
they're mixed, we mark it as "changed".
next prev parent reply other threads:[~2017-04-11 0:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 2:42 bug#26066: 26.0.50; vc-git-status gives wrong result Jonathan Ganc
2017-03-14 13:45 ` npostavs
2017-03-16 0:42 ` npostavs
2017-03-16 0:48 ` Dmitry Gutov
2017-03-16 2:40 ` Jonathan Ganc
2017-03-21 9:19 ` Dmitry Gutov
2017-03-21 16:10 ` Jonathan Ganc
2017-03-22 12:11 ` Michael Heerdegen
2017-03-22 16:20 ` Dmitry Gutov
2017-03-23 2:18 ` Jonathan Ganc
2017-03-31 3:16 ` Jonathan Ganc
2017-04-10 2:16 ` Jonathan Ganc
2017-04-10 2:58 ` npostavs
2017-04-10 3:26 ` Dmitry Gutov
2017-04-10 4:41 ` Jonathan Ganc
2017-04-10 6:05 ` Eli Zaretskii
2017-04-10 7:35 ` Thien-Thi Nguyen
2017-04-10 23:46 ` Dmitry Gutov
2017-04-10 4:43 ` Jonathan Ganc
2017-04-10 23:26 ` Dmitry Gutov
2017-04-11 0:07 ` Dmitry Gutov [this message]
2017-04-11 3:52 ` Jonathan Ganc
2017-04-11 13:08 ` Jonathan Ganc
2017-04-11 23:27 ` Dmitry Gutov
2017-04-11 23:36 ` Dmitry Gutov
2017-04-14 0:42 ` Jonathan Ganc
2017-04-23 18:21 ` Jonathan Ganc
2017-04-23 22:28 ` Noam Postavsky
2017-04-23 22:45 ` Stefan Monnier
2017-04-24 0:50 ` Jonathan Ganc
2017-04-24 9:20 ` Andreas Schwab
2017-04-25 15:38 ` Jonathan Ganc
2017-04-25 23:49 ` Dmitry Gutov
2017-04-26 3:18 ` Jonathan Ganc
2017-05-01 1:43 ` Dmitry Gutov
2019-06-24 23:01 ` Lars Ingebrigtsen
2020-08-10 15:05 ` Lars Ingebrigtsen
2017-05-01 1:57 ` Dmitry Gutov
2017-05-01 19:22 ` Jonathan Ganc
2017-05-01 19:42 ` Eli Zaretskii
2017-05-01 22:13 ` Dmitry Gutov
2017-03-18 2:38 ` Jonathan Ganc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505388da-e642-8c98-35c0-261d09ff13e1@yandex.ru \
--to=dgutov@yandex.ru \
--cc=26066@debbugs.gnu.org \
--cc=jonganc@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).