From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port Date: Sat, 17 Aug 2024 11:41:33 +0300 Message-ID: <5045.2987708681$1723884172@news.gmane.org> References: <86bk1r661g.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="944"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72526@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 17 10:42:44 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfF1I-00006o-Hx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Aug 2024 10:42:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfF12-0003MS-5N; Sat, 17 Aug 2024 04:42:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfF0z-0003Lt-33 for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 04:42:25 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfF0y-0006bl-8V for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 04:42:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=FDG0WWAC+3mTRLVO78aThowpfHfW8bwuzsiCHWi9ZV4=; b=mOX7S6bDaZWyDwGl/3Dppasy0ijRk7/TdwdNJ0VkvpMuzpARe0nHLWY0B/L6k1gHxxWOGfG9JTYEKjzLrL51iCh93QNf67odQg9YIZxYAZF5MqlmS4q81I9Ab7n+0EYWEYTdEhb0PlaqneIQNGx0Z0YPz5Giz2KK0X4K+YIBBfTkgepi76ufVvIS4YrTEO640NbKTdJwk/CwPp3pWfZZtCvNASAHknhBj80aGEHXPFOpR7ib2xWRPx6n7b/bxvxSJtyhVIv/NROPygsSIe4Xcm/6JESodjxrBMjaj6FxCkPt47ZGU5C5jipAwss3DqmHdJz53bLBWU5mB7ixnNMkiA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfF1a-0001Fj-EH for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 04:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2024 08:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72526-submit@debbugs.gnu.org id=B72526.17238841744796 (code B ref 72526); Sat, 17 Aug 2024 08:43:02 +0000 Original-Received: (at 72526) by debbugs.gnu.org; 17 Aug 2024 08:42:54 +0000 Original-Received: from localhost ([127.0.0.1]:53449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfF1S-0001FH-5p for submit@debbugs.gnu.org; Sat, 17 Aug 2024 04:42:54 -0400 Original-Received: from thaodan.de ([185.216.177.71]:39344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfF1P-0001F0-CB for 72526@debbugs.gnu.org; Sat, 17 Aug 2024 04:42:52 -0400 Original-Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154]) by thaodan.de (Postfix) with ESMTPSA id 1011AD00039; Sat, 17 Aug 2024 11:41:35 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1723884095; bh=/kandhwzaMP9tJ8Ib11/E6HRBhVJVQ9g+7Gkeax0cS4=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=O8JHveGWWRG9m6W/2wEmnPYm0ljVziWg6/hAS5jLuNbLlidBAnGlpDao7Ht8ViSeR 5SHhkpG05qXL77N36jw672GCaB0/vNnRmqrY41+ciofsE3gGIBt+hOWMWXpxsihLsC rhjOSY9GQdamJang93mgTmEjmL2iQc0VTjaGMAV4Vkngz9ESAxtBF4U07UhCpmtOBx bT8/9UArS2MltZrriL63FbejB023ZGGFjILeBI6pf69Kw+DDK/JbGfVa2tzjOqEUak rC1wJNOUBLnPGvkA+L2FgOK2ss3G1o2bk/ipC3hVslOCXkE8wS1ACQl96MxQd+1//7 pMLDl0eq+u96TlT8wUXwwTYysOArOXecO8YTwynEhaAo+K9gwsAuU714gWDD+BeJmc P7UtwVOfR2/rzYvBSZY2ABfwse12Tots47Umx84rt6ICwfh5SarcI2aUNc3RMtjlCh ee29ifn46TIighAsBDaDOGfVGDTwNY6+RdEJY80dyfOhqEZdLkLabAEpJYCJIWWrAh 7gu1cQ37hTkWrZWYbazFlocqm/sfdwn0C6Hpvzy9LaQxYF04lkMCJsawsNWnnkqKlG qHpdFc2IVbMNYo6IDAcXxaVneLuLQKyxI6kcsewgGSoU4d6L3hglK/I2cY9AMGd3eA xjEaHy+kao9Dcq9w/6ExCqz0= In-Reply-To: <86bk1r661g.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Aug 2024 09:02:19 +0300") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290236 Archived-At: Eli Zaretskii writes: >> Date: Fri, 16 Aug 2024 23:02:51 +0300 >> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Could someone please review my patch? > > Sorry, I don't see any experts around to ask to do that. Maybe the maintainer of the url package? > Maybe if you'd posted a more detailed description of the problem and > its context, someone could follow your arguments and do a meaningful > review. E.g., it sounds from your description like the case of URLs > where it currently fails was not meant to be supported by this > library? If so, perhaps an alternative is to submit to this library > only URLs that it supports, like after stripping the port part? The problem is that the user in url-basic-auth when handling urls like ://@ isn't forwarded to auth-source. Further it also appends to port to the hostname of host which means that the host is invalid since the hostname includes the port number. >From what I read when looking at url-auth.el at line 84 it does support this kind of case of url as it already handles the same type of url when it deals with ://:@. > On another level: please make sure you leave 2 spaces between > sentences in comments, strings, and commit log messages. And I don't > think the 3rd patch belongs to this issue, so let's not include it in > this discussion. Sure.