From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@jurta.org>
Cc: 12253@debbugs.gnu.org
Subject: bug#12253: Restore window start position
Date: Sat, 25 Aug 2012 15:40:26 +0200 [thread overview]
Message-ID: <5038D5CA.5000502@gmx.at> (raw)
In-Reply-To: <8762874wyk.fsf@mail.jurta.org>
> These functions might be used non-interactively,
> where the *info* buffer is not displayed in any window,
> e.g.:
>
> (with-current-buffer "*info*"
> (Info-history-back))
Aha
> so in this case `goto-char' should be used instead of `set-window-point'
> in `Info-history-back' and other similar functions.
>
> It is true that in the latest patch, `set-window-start'
> is not guarded against this use case.
This must have been the inconsistency that troubled my subconsciousness.
> To guarantee that the
> function operates on the window that displays the current buffer,
> we could add the following condition (this patch is based on the
> previous patch that adds `set-window-start'):
>
> === modified file 'lisp/info.el'
> --- lisp/info.el 2012-08-22 23:45:47 +0000
> +++ lisp/info.el 2012-08-25 00:28:00 +0000
> @@ -2225,7 +2225,8 @@ (defun Info-history-back ()
> (Info-find-node filename nodename)
> (setq Info-history (cdr Info-history))
> (setq Info-history-forward history-forward)
> - (set-window-start (selected-window) ostart t)
> + (when (eq (window-buffer) (current-buffer))
> + (set-window-start (selected-window) ostart t))
> (goto-char opoint)))
>
> If you agree that this is the right thing to do
> then other places could be changed accordingly as well.
I agree. How do you handle the case where *info* is not in the selected
window but some other one?
martin
next prev parent reply other threads:[~2012-08-25 13:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 22:17 bug#12253: Restore window start position Juri Linkov
2012-08-22 7:08 ` martin rudalics
2012-08-22 23:38 ` Juri Linkov
2012-08-23 8:48 ` martin rudalics
2012-08-23 22:00 ` Juri Linkov
2012-08-24 9:45 ` martin rudalics
2012-08-25 0:29 ` Juri Linkov
2012-08-25 13:40 ` martin rudalics [this message]
2012-08-25 19:29 ` Juri Linkov
2012-08-28 8:53 ` Juri Linkov
2013-01-16 16:57 ` Drew Adams
2013-01-18 22:42 ` Drew Adams
2013-01-19 10:17 ` Juri Linkov
2013-01-19 15:03 ` Drew Adams
2013-03-29 16:56 ` Drew Adams
2021-05-11 14:33 ` Drew Adams
2021-05-11 17:53 ` Juri Linkov
2021-05-11 18:46 ` bug#12253: [External] : " Drew Adams
2021-05-11 19:29 ` Juri Linkov
2021-05-11 20:18 ` Drew Adams
2021-05-12 8:47 ` martin rudalics
2024-01-10 11:31 ` Stefan Kangas
2024-01-10 17:16 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5038D5CA.5000502@gmx.at \
--to=rudalics@gmx.at \
--cc=12253@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).