From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#41682: makefile-gmake-mode does not trigger "eval-after-load"'s hooks Date: Wed, 03 Jun 2020 13:25:01 +0300 Message-ID: <5033bb634ff86730d34392115282169363298dc1.camel@yandex.ru> References: <7874555c5ba73c3b6b7c9c07e6bde015aa1c7fc7.camel@yandex.ru> <87o8q01mcp.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62050"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.36.3 Cc: 41682@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 03 12:26:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgQb9-000G06-Ra for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Jun 2020 12:26:15 +0200 Original-Received: from localhost ([::1]:44310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgQb8-0004vm-So for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Jun 2020 06:26:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgQaw-0004tu-UV for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2020 06:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgQaw-0002rV-Kh for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2020 06:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgQaw-0003AG-HN for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2020 06:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jun 2020 10:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41682 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 41682-submit@debbugs.gnu.org id=B41682.159117991312089 (code B ref 41682); Wed, 03 Jun 2020 10:26:02 +0000 Original-Received: (at 41682) by debbugs.gnu.org; 3 Jun 2020 10:25:13 +0000 Original-Received: from localhost ([127.0.0.1]:42092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgQa9-00038v-Dx for submit@debbugs.gnu.org; Wed, 03 Jun 2020 06:25:13 -0400 Original-Received: from forward103j.mail.yandex.net ([5.45.198.246]:56445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgQa5-00034Y-Ox for 41682@debbugs.gnu.org; Wed, 03 Jun 2020 06:25:12 -0400 Original-Received: from mxback14o.mail.yandex.net (mxback14o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::65]) by forward103j.mail.yandex.net (Yandex) with ESMTP id 949D76742FCC; Wed, 3 Jun 2020 13:25:02 +0300 (MSK) Original-Received: from iva1-bc1861525829.qloud-c.yandex.net (iva1-bc1861525829.qloud-c.yandex.net [2a02:6b8:c0c:a0e:0:640:bc18:6152]) by mxback14o.mail.yandex.net (mxback/Yandex) with ESMTP id Cs5Syr9gX2-P2dqFTd0; Wed, 03 Jun 2020 13:25:02 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1591179902; bh=SlSDHlAN05v/s5vHiDOdrYDaWt02UgLu6pSgrj85Jyw=; h=In-Reply-To:Cc:To:From:Subject:References:Date:Message-ID; b=oJQXGsh8ADb1U413pWvy2SvTpp3zXksqAbPHblcqrI9jmsgsWZqkLoTKq9kVcajRL AAHyRGtttc/3QW4wXOQMGpzw6V44+MkqiCeuUcKWSgGlpS3bRLBvYfgfdtCVg++HNy hOK/9SOz29NM5CdAJPqoEDvGDii6+o1JVuynR/kc= Authentication-Results: mxback14o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by iva1-bc1861525829.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id LdQKAsM8jU-P14iKD6R; Wed, 03 Jun 2020 13:25:01 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) In-Reply-To: <87o8q01mcp.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181449 Archived-At: On Wed, 2020-06-03 at 11:21 +0100, Basil L. Contovounesios wrote: > tags 41682 + notabug > quit > > Konstantin Kharlamov writes: > > > Functions added with (eval-after-load 'makefile-gmake-mode …) do > > not > > trigger when the mode is enabled > > I think you've misunderstood what eval-after-load does. > > 'makefile-gmake-mode' is a major mode function defined in the file > make-mode.el which provides the named feature 'make-mode'. See > (info "(elisp) Named Features") and (info "(elisp) Hooks for > Loading"). > > https://www.gnu.org/software/emacs/manual/html_node/elisp/Named-Features.html > https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks-for-Loading.html > > eval-after-load, and its newer, preferred sibling with-eval-after- > load, > register some Lisp to be run when a file or named feature is or has > already been loaded. > > If you want to register some Lisp to run only once, after make- > mode.el > is loaded (and makefile-gmake-mode has been defined), then you should > write: > > (with-eval-after-load 'make-mode > (foo) > (bar)) > > If you want to register some Lisp to run every time makefile-gmake- > mode > is enabled, then you should write: > > (add-hook 'makefile-gmake-mode-hook #'foo) > > If you want to register some Lisp to run every time any make-mode.el > major mode is enabled, then you should write: > > (add-hook 'makefile-mode-hook #'foo) > > Is there some other case you're trying to address, or can this bug be > closed? Thank you for through explanation! Sure, this bug can be closed.