From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#11935: XINT etc. should be functions Date: Mon, 16 Jul 2012 07:54:07 -0700 Organization: UCLA Computer Science Department Message-ID: <50042B0F.9050105@cs.ucla.edu> References: <500039B7.8050106@cs.ucla.edu> <5002C895.4080400@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1342450536 9496 80.91.229.3 (16 Jul 2012 14:55:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 16 Jul 2012 14:55:36 +0000 (UTC) Cc: 11935@debbugs.gnu.org, rms@gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 16 16:55:34 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sqmhx-0004p4-Sr for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jul 2012 16:55:34 +0200 Original-Received: from localhost ([::1]:57556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqmhx-00022W-5b for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jul 2012 10:55:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqmhg-0001yC-09 for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2012 10:55:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqmhY-0004Tm-A2 for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2012 10:55:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqmhY-0004Tf-5z for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2012 10:55:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SqmnG-0005y2-EM for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2012 11:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jul 2012 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11935-submit@debbugs.gnu.org id=B11935.134245080522806 (code B ref 11935); Mon, 16 Jul 2012 15:01:02 +0000 Original-Received: (at 11935) by debbugs.gnu.org; 16 Jul 2012 15:00:05 +0000 Original-Received: from localhost ([127.0.0.1]:44304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqmmK-0005vb-O4 for submit@debbugs.gnu.org; Mon, 16 Jul 2012 11:00:05 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:48121) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqmmJ-0005vI-6l for 11935@debbugs.gnu.org; Mon, 16 Jul 2012 11:00:04 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 8BEE239E800D; Mon, 16 Jul 2012 07:54:07 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KumWRhRdS9gg; Mon, 16 Jul 2012 07:54:07 -0700 (PDT) Original-Received: from [192.168.1.4] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 1FE1F39E800B; Mon, 16 Jul 2012 07:54:07 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61985 Archived-At: On 07/15/2012 03:06 PM, Stefan Monnier wrote: > I always run with -O0 (plus ENABLE_CHECKING, and to add insult to > injury, on Atom-level platforms), so I'd appreciate if you could ensure > those functions are inlined even in -O0. That's easy enough to arrange, without being intrusive -- it would add maybe 10 lines to the patch. Although the benchmark numbers are a bit scary, they greatly exaggerate the real-life performance effect, because most of Emacs's CPU time is spent elsewhere. I just now ran Emacs with the patch compiled with -g -O0, on my main laptop, which is also quite limited and slow (Pentium M 1.86 GHz, circa 2005), and interactive performance was fine. Your mileage may vary, of course, but it might make sense to not inline those functions even with -O0. There are important advantages to not inlining: you can put breakpoints on them, for example. So it might make sense to inline them only as an option.