From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string Date: Mon, 05 Dec 2022 13:58:33 +0000 Message-ID: <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28771"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 14:59:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2C0F-0007IR-A8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 14:59:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2Bzz-00045t-HY; Mon, 05 Dec 2022 08:59:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Bzq-00045Q-Mh for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:59:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2Bzq-0007sx-9l for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2Bzp-0001BN-VQ for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59833 X-GNU-PR-Package: emacs Original-Received: via spool by 59833-submit@debbugs.gnu.org id=B59833.16702487264532 (code B ref 59833); Mon, 05 Dec 2022 13:59:01 +0000 Original-Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 13:58:46 +0000 Original-Received: from localhost ([127.0.0.1]:36175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Bza-0001B2-6l for submit@debbugs.gnu.org; Mon, 05 Dec 2022 08:58:46 -0500 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:31497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2BzY-0001Av-Kz for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 08:58:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670248718; x=1670507918; bh=1tUdfNEIpud5SqFFoQ6FqZ8fcmVBWdvoGMU8Exl6poA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=T7hoVgsWNUArK1CU9cZu2tdj2Fekt+/ujcoJFbY9h3aQz2ZLUKkvvNylVxDwwAlGt lDKv5z5o1BZZLEjwnkoZfdv34mxZGkfXYmiyXEa98nYfQbiIPNpFMCyXw0dpq+LRI8 Ro9epIjilamCFLkB6KT5HRNh7qw6UqgJL6/VqS01E7AT1rM6AE7U/M4JeMSBOAXt0D bebmwWaZ4jywqCivb/C2I6H0LgXZ7qY1DDYijff4/4MjyBzn7pGlpB3FjuWxxKS0Wn GobsLsAaklOu7Q6j+upgf+o5nbU8ivbGSGkdRMPiNnA+4lMEPXf8HdActWJ77w5qoj bV/YOUue/Lkyg== In-Reply-To: <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250026 Archived-At: On Monday, December 5th, 2022 at 08:52, Randy Taylor wrote: >=20 > On Monday, December 5th, 2022 at 06:24, Theodor Thornhill theo@thornhill.= no wrote: >=20 > > Jostein Kj=C3=B8nigsen jostein@secure.kjonigsen.net writes: > >=20 > > > Hey everyone. > > >=20 > > > When opening a JSON-file in a build from emacs git emacs-29 > > > release-branch, Emacs still defaults to json-mode. > > >=20 > > > Fontification in json-mode looks correct and proper. > > >=20 > > > When trying to insteas use json-ts-mode, literally everything is > > > fontified as strings. > > >=20 > > > When I change the code to disable the string-fontification rule, this > > > yields a buffer where everything is fontified using default-face. Tha= t > > > is, no other fontification is taking place. > > >=20 > > > Have this mode really been tested? Should it be working? Or is there = an > > > error on my end? > > >=20 > > > Could someone else please give json-ts-mode a try? > >=20 > > Yeah, you are correct. It seems we've had a regression in this commit, > > 0ed313642227afdeccf48057eea458edca9d2962. > >=20 > > I believe this is the offending commit - what do you think, Randy? > >=20 > > Specifically the lhs should be fontified differently than the rhs, so > > not everything is a string. > >=20 > > Do you want to do that, Randy, or should I? > >=20 > > Theo >=20 >=20 > Can someone show me an example JSON file that shows this problem? Everyth= ing looks the same for me in json-mode and json-ts-mode, except for the jso= n-ts-mode extras (even with Theo's patch) both with my own Emacs config and= emacs -Q. I must be doing something very silly. Scratch that, I got Theo's patch working, needed to rebuild. Looks good to = me (although it would be nice to keep treesit-font-lock-feature-list alphab= etized Theo ;)). json-mode still fontifies pretty much everything as a string though (at lea= st for me).