From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.bugs Subject: bug#25188: Initialization of `global-edebug-map' is not safe Date: Tue, 13 Dec 2016 00:45:07 +0100 Message-ID: <4f637d8d-29c0-d6cb-6e7e-824bdb173601@Alexander.Shukaev.name> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1481587126 14812 195.159.176.226 (12 Dec 2016 23:58:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Dec 2016 23:58:46 +0000 (UTC) To: 25188@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 13 00:58:43 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGaUS-00030z-TV for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Dec 2016 00:58:41 +0100 Original-Received: from localhost ([::1]:34381 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGaUX-00088z-8V for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Dec 2016 18:58:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGaIJ-0006Nc-0r for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:46:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGaIF-00032y-5I for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:46:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cGaIF-00032t-27 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cGaIE-0006tv-SC for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alexander Shukaev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2016 23:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25188 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.148158632526465 (code B ref -1); Mon, 12 Dec 2016 23:46:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Dec 2016 23:45:25 +0000 Original-Received: from localhost ([127.0.0.1]:39742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGaHd-0006sn-2p for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:45:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGaHc-0006sb-61 for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:45:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGaHW-0002oM-5k for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:45:18 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40599) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGaHW-0002oA-2h for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:45:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGaHU-0005jo-T4 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:45:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGaHQ-0002n1-Uh for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:45:16 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50652) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGaHQ-0002mY-OY for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:45:12 -0500 Original-Received: from mfilter12-d.gandi.net (mfilter12-d.gandi.net [217.70.178.129]) by relay8-d.mail.gandi.net (Postfix) with ESMTP id 2865340496 for ; Tue, 13 Dec 2016 00:45:10 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter12-d.gandi.net Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by mfilter12-d.gandi.net (mfilter12-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id 4m63UJklSDLk for ; Tue, 13 Dec 2016 00:45:08 +0100 (CET) X-Originating-IP: 88.68.181.111 Original-Received: from [192.168.3.110] (dslb-088-068-181-111.088.068.pools.vodafone-ip.de [88.68.181.111]) (Authenticated sender: forum@alexander.shukaev.name) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 6FD3C40406 for ; Tue, 13 Dec 2016 00:45:08 +0100 (CET) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126940 Archived-At: Hi, first of all, in 'edebug.el', the ;; If you wish to change the default edebug global command prefix, change: ;; (setq edebug-global-prefix "\C-xX") is invalid because the name of the variable is actually `global-edebug-prefix'. But that's just a minor point. Consider (defvar global-edebug-map (let ((map (make-sparse-keymap))) (define-key map " " 'edebug-step-mode) (define-key map "g" 'edebug-go-mode) (define-key map "G" 'edebug-Go-nonstop-mode) (define-key map "t" 'edebug-trace-mode) (define-key map "T" 'edebug-Trace-fast-mode) (define-key map "c" 'edebug-continue-mode) (define-key map "C" 'edebug-Continue-fast-mode) ;; breakpoints (define-key map "b" 'edebug-set-breakpoint) (define-key map "u" 'edebug-unset-breakpoint) (define-key map "x" 'edebug-set-conditional-breakpoint) (define-key map "X" 'edebug-set-global-break-condition) ;; views (define-key map "w" 'edebug-where) (define-key map "W" 'edebug-toggle-save-windows) ;; quitting (define-key map "q" 'top-level) (define-key map "Q" 'edebug-top-level-nonstop) (define-key map "a" 'abort-recursive-edit) ;; statistics (define-key map "=" 'edebug-display-freq-count) map) "Global map of edebug commands, available from any buffer.") (global-unset-key global-edebug-prefix) (global-set-key global-edebug-prefix global-edebug-map) and imagine that somebody has customized `global-map' in such a way that it has no "\C-x" prefix command at all. Then of course the above code will fail. Furthermore, if one does not want to pollute the `global-map' with `global-edebug-map', one cannot simply set `global-edebug-prefix' to nil because this would also fail. I believe `global-edebug-map' should support the nil value which would mean that the above code is disabled completely. Looking forward to fix. Regards, Alexander