From: Dmitry Gutov <dgutov@yandex.ru>
To: Theodor Thornhill <theo@thornhill.no>, Eli Zaretskii <eliz@gnu.org>
Cc: 47287@debbugs.gnu.org
Subject: bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project
Date: Mon, 22 Mar 2021 01:54:04 +0200 [thread overview]
Message-ID: <4f5e3918-e133-88e4-b5c9-90a81e348497@yandex.ru> (raw)
In-Reply-To: <m1czvsgkjd.fsf@Frende-MacBook.lan>
On 22.03.2021 01:21, Theodor Thornhill via Bug reports for GNU Emacs,
the Swiss army knife of text editors wrote:
> Does this approach seem reasonable to you?
It's fine, but it would be better for both function's argument to follow
projectile-add-known-project (meaning, call it 'project-root').
Regarding report-message, I figured it would just be a separate
'message' call in both caller functions. Apparently that might to this
message appearing more often (due to the requested project not actually
appearing in project--list?), but I wonder if we shouldn't replace that
when-let with a presence assertion instead.
Anyway, the latter is not a big deal; project--remove-from-project-list
can be changed at any time later.
next prev parent reply other threads:[~2021-03-21 23:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 23:28 bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 0:27 ` Dmitry Gutov
2021-03-21 6:33 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 11:42 ` Dmitry Gutov
2021-03-21 6:17 ` Eli Zaretskii
2021-03-21 6:38 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 12:12 ` Dmitry Gutov
2021-03-21 12:15 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 23:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 23:54 ` Dmitry Gutov [this message]
2021-03-22 7:48 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 11:52 ` Dmitry Gutov
2021-03-22 12:29 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-23 11:37 ` Eli Zaretskii
2021-03-23 12:30 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-23 12:43 ` Eli Zaretskii
2021-03-23 12:50 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-24 23:17 ` Dmitry Gutov
2021-03-25 0:03 ` Basil L. Contovounesios
2021-03-25 1:04 ` Dmitry Gutov
2021-03-25 6:15 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-25 7:29 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 13:24 ` Dmitry Gutov
2021-09-21 18:36 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f5e3918-e133-88e4-b5c9-90a81e348497@yandex.ru \
--to=dgutov@yandex.ru \
--cc=47287@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).