From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#65315: 30.0.50; vc-dir fails with Git < 2.7.0 Date: Wed, 16 Aug 2023 04:33:04 +0300 Message-ID: <4f3914ec-679e-d16f-4938-997ac6392fad@gutov.dev> References: <25819.51571.336510.375273@orion.rgrjr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5443"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Bob Rogers , 65315-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 16 03:34:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qW5QU-00017W-Ph for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Aug 2023 03:34:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qW5QC-0002Tg-BM; Tue, 15 Aug 2023 21:34:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW5QA-0002TA-8W for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2023 21:34:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qW5QA-0007tc-1H for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2023 21:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qW5Q9-0001me-Ru for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2023 21:34:01 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Aug 2023 01:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65315 X-GNU-PR-Package: emacs Mail-Followup-To: 65315@debbugs.gnu.org, dmitry@gutov.dev, rogers@rgrjr.com Original-Received: via spool by 65315-done@debbugs.gnu.org id=D65315.16921496006805 (code D ref 65315); Wed, 16 Aug 2023 01:34:01 +0000 Original-Received: (at 65315-done) by debbugs.gnu.org; 16 Aug 2023 01:33:20 +0000 Original-Received: from localhost ([127.0.0.1]:38398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qW5PU-0001lg-B9 for submit@debbugs.gnu.org; Tue, 15 Aug 2023 21:33:20 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qW5PP-0001lP-0V for 65315-done@debbugs.gnu.org; Tue, 15 Aug 2023 21:33:18 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id ECDB15C0063; Tue, 15 Aug 2023 21:33:08 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 15 Aug 2023 21:33:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1692149588; x=1692235988; bh=iiD5bN091mEUrN7OwQwgJFphQmlLxi/P+Rx uGFsFtMY=; b=QOJ2LNyB98r8hpBzPsnbBUuoEmMOfpFTHdDALPYOxI93Nj5dnQe bNSOZ6zhIUQxoTEw4Sa3tu2SHfp6PMc6bF0Y9SOw3yxksh9xup6p4NGeF8EcAMLR cxiKJWusifktukOMzmV/M7e3Bq2D9iMOBq/YFc067B57nuzpDv19As9XhQ0GqhhS hyA68UWfsxBoioAGd+KLD/KLH1z0U6IS1zw36R6vm049mHGf148xDnnJ+QuN4zf4 UwOv5rSPpBSI336A3gLi0cjPKmeUNHQb80ksoDy3QygpdSvKAbSwvVwmTJrGaWuc gHLwBkb4pbVAOg3nk+0PssqCKs7kENsH0jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1692149588; x= 1692235988; bh=iiD5bN091mEUrN7OwQwgJFphQmlLxi/P+RxuGFsFtMY=; b=L YNZ8rZ03zAjkX6lyELzzhFPCDtGs9BfWZ+Z9fdnzrhv0saC6OQYKIjpq6eqor+sb jsoMo1TjC3C2yHqXtunTW37tzCaISeuWMi9BSqwVD9KnZJS2aR6+yTmLTPWle3sh YxsZtDgGOazhXUyPRfry9dDtRJDD5k71hpUyNbI8HW2O84rUqozCoB3Qc/y8rIDH YvMIBmifi9D5IAagqMpXMGI5OTVx2qy3poWM4DPMtcFfKqqAARKmbH7b9fAzn9/9 mDzsEZzAfvh6LNjxLtn11rbXKsLN4Q8MfiBvLQW3PZiXzHkt0mu98mhlbKiW0/sA 6OAwJA8BE1kk3Gqz9LD5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtkedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeghedthedujeeiteeutddtjeekheejteeukeehffdutdejuedvfeevueeviedu udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Aug 2023 21:33:07 -0400 (EDT) Content-Language: en-US In-Reply-To: <25819.51571.336510.375273@orion.rgrjr.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267533 Archived-At: Version: 30.1 On 15/08/2023 21:52, Bob Rogers wrote: > 1. On a system with a version of Git older than 2.7.0, navigate to a > git-controlled directory and invoke "emacs -Q". > > 2. With this as the default directory, invoke vc-dir. This fails > with the error "vc-do-command: Failed (status 129): git --no-pager > remote get-url origin ." > > This is because the "get-url" subcommand of "git remote", used by > vc-git-repository-url, was added in 2.7.0 [1]. The attached patch > against master rev 1db7e8eba961e88181879213dd5374ad9e87ac76 uses "git > config" in a way that works in both old and new systems (tested with git > 2.1.2 and git 2.35.3). Thanks! Pushed to master. > Of course, supporting 7+-year-old versions of git is probably not a > high priority, so I won't be too disappointed if this fix is rejected. > On the other hand, it's a small change, and having vc-dir fail on any > system, especially when using Git, puts a big damper on being able to > use Emacs to hack on things in older systems, so I think it's worth > having. I'm not a fan of spending too much time on older versions myself, but the patch is indeed small, and we're still making allowances for versions older than that still. Speaking of older systems, though, I would hope they have similarly old repositories with suitably old Emacs versions (or, if you build from source, there is a respective tag in the repo). We do have to drop compatibilities when stuff is old enough.