From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#45264: 26.3; `face-remap-set-base' seems to be bugged Date: Sat, 19 Dec 2020 10:32:16 -0800 (PST) Message-ID: <4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default> References: <> <<833602umgb.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45264@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 19 19:35:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqh4e-0006t7-2D for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Dec 2020 19:35:24 +0100 Original-Received: from localhost ([::1]:46952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqh4d-0000Dr-4q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Dec 2020 13:35:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqh4I-0000DJ-5g for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 13:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqh4H-0002Ma-Ug for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 13:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqh4H-0001Xv-Ra for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 13:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Dec 2020 18:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45264 X-GNU-PR-Package: emacs Original-Received: via spool by 45264-submit@debbugs.gnu.org id=B45264.16084028695895 (code B ref 45264); Sat, 19 Dec 2020 18:35:01 +0000 Original-Received: (at 45264) by debbugs.gnu.org; 19 Dec 2020 18:34:29 +0000 Original-Received: from localhost ([127.0.0.1]:43147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqh3l-0001X0-74 for submit@debbugs.gnu.org; Sat, 19 Dec 2020 13:34:29 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:33974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqh3j-0001Wm-AU for 45264@debbugs.gnu.org; Sat, 19 Dec 2020 13:34:28 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJIYJ8B069043; Sat, 19 Dec 2020 18:34:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=jSneAbaN6oN/7Kn7qX+/NgIrV9xgzhC2prRAMOiSgqQ=; b=qju8PxMWdfbjBQfOVXBT+UY+OgxUEyny/Bm025EOFH1LQZjBtkSd6PSypQDcMYKPgFo6 LYnv7xbtye1OcqAYpSrZk7P0WL35o4Va/pCpmZl0j/TE8+2D3tQaZoSL+cNvSCXVJDSM nbxUxGgfH8RwBHVs6F10kmMtAn/KmTgW344SjYvWhgAAezy2+YBeqLoAKab8MjQZOLRU qL1lipP83DkMj8oqw5QK59T+0jljVhRh9m4SfcWDPO7I7F3Asl+WWzA/5BlXXAPV1Dli wVZVlByULX2r4EY0zdNEt7qHNt6Zne3BaIB3U4BWdTZKmXLrQ+lGsQy3VwT29ZV09z26 ww== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 35h71asdjs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 19 Dec 2020 18:34:19 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJIPPJe032721; Sat, 19 Dec 2020 18:32:18 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 35h8uh14hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Dec 2020 18:32:18 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BJIWHVv029141; Sat, 19 Dec 2020 18:32:17 GMT In-Reply-To: <<833602umgb.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190137 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 clxscore=1011 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 impostorscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190138 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196413 Archived-At: > > Is there a doc bug (both manual and doc string)? Or is there a code > > bug? Or am I missing something? >=20 > I don't see anything wrong with the documentation yet. One needs to > know and understand what is a "face spec", and then everything falls > into its place. The &rest part is also a big hint. >=20 > Can I turn the table and ask you why you thought the argument could be > a list of one or more faces? The doc string says "should FORM a list > of faces", it doesn't say it should BE a list of faces. And since > when does &rest specify a single argument that is a list? The confusion is not from not understanding what a face spec is. I think I know what a face spec is. The confusion is from the doc not saying explicitly that each element of SPECS is a face spec, and NOT a face. Please consider making that explicit (clear). 1. I didn't suggest (at all) that &rest specifies a single arg that is a list. Quite the contrary - the answer I gave to that SE question explicitly made that exact point. 2. "why you thought the argument could be a list of one or more faces?" The doc string explicitly says that elements of SPECS can be face names: Each list element should be either a face name or... 3. The predicate that tests for a face is `facep', and it doesn't return non-nil for a face spec. Its doc explicitly says that it tests whether its arg is a "face name", which can be a string or a symbol. Putting #2 and #3 together, the doc for SPECS does indeed say that elements of SPECS can be faces. 4. I strongly suggest that you change the language. "FORM" as a verb here is not clear, and this is apparently not about faces as arguments; it's about face specs. Face specs can be said to define (or "form") faces, but they are not faces - they don't satisfy `facep'. ___ Another possibility is perhaps to fix the behavior, so that it does what its doc says: allow elements of SPECS to "be either a face name or a property list of...". Allow faces, not just face specs.