From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: tanzer--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55574: 28.1; desktop-kill not included in kill-emacs-hook anymore Date: Sun, 22 May 2022 13:23:03 -0000 Message-ID: <4ef4f41e-d9d2-11ec-a163-f2f1999dd7e9@gg32.com> Reply-To: tanzer@gg32.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36066"; mail-complaints-to="usenet@ciao.gmane.io" To: 55574@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 22 15:24:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nslZb-0009Ce-Gv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 May 2022 15:24:43 +0200 Original-Received: from localhost ([::1]:37890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nslZa-0001vl-Ai for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 May 2022 09:24:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nslYw-0001vb-5Z for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 09:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nslYv-0004Ij-Sa for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 09:24:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nslYv-0006Gp-PD for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 09:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: tanzer@gg32.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 May 2022 13:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55574 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165322579724049 (code B ref -1); Sun, 22 May 2022 13:24:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 May 2022 13:23:17 +0000 Original-Received: from localhost ([127.0.0.1]:43967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nslYC-0006Fp-TN for submit@debbugs.gnu.org; Sun, 22 May 2022 09:23:17 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:37994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nslYA-0006Fh-Rl for submit@debbugs.gnu.org; Sun, 22 May 2022 09:23:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nslYA-0001sn-Mz for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 09:23:14 -0400 Original-Received: from mx0.gg32.com ([168.119.248.232]:7135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nslY8-0004Ex-5e for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 09:23:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=20220514; bh=W7SRYF1++ep qDQ9BCkz3jHqRCr3MZYWaXXVAst/JhyA=; h=from:to:subject:date:reply-to; d=gg32.com; b=PKpv/juRtm8GSA3uMXuMNS9suohqMMNvlXw4yUkFEBfmLrl6u9mZYk78 xuy5SHhEh21vpVZ6VO3TH3DGmMpc4kydWV2ZfLyPLHGg0SpzJn3oUwksjD0FqubAUKwPH5 RX/T2pFYW+Ol4vRvKNDEz1wCeoOnVEri/cF9S2aLWwiB+3hKmyYLlP0yvqsOwUp5ppOV14 1kKRbaUeV31F8xGXDWaJvU7+KvR2DvPvBdouVO0SGJD006fkpIFByLO8I99otrp+wUlWEQ 8XA8qbPdDvdQ0Ta9U1Von2ttg2WIIVZ4FOj/vsYpV4rFb2ECeirUSI0gUys8GMfk8vYTtX VIr9Ug== Original-Received: by mx0.gg32.com (OpenSMTPD) with ESMTP id 2e045443; Sun, 22 May 2022 14:23:04 +0100 (WEST) X-mailer: PMA 0.8.0 Received-SPF: pass client-ip=168.119.248.232; envelope-from=tanzer@gg32.com; helo=mx0.gg32.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" X-ACL-Warn: , tanzer@gg32.com Xref: news.gmane.io gmane.emacs.bugs:232900 Archived-At: Before Emacs 28, `desktop-kill` was included in `kill-emacs-hook` if `desktop-save-mode` was enabled. In Emacs 28, `desktop-kill` is included in `kill-emacs-query-functions` instead. Therefore the desktop is not saved and the desktop lock not removed when `kill-emacs` is used to exit Emacs. Unfortunately, the new behavior is not documented in the NEWS file. The behavior can be reproduced by evaluating the following elisp snippet in an Emacs 28.1 instance started with `emacs -Q`: (desktop-save-mode 1) (message "kill-emacs-hook: %s" kill-emacs-hook) In Emacs 28.1, it will display: "kill-emacs-hook: nil" In Emacs 27.2, it will display: "kill-emacs-hook: (desktop-kill)" Please revoke the change or document it properly. In GNU Emacs 28.1 (build 1, aarch64-apple-darwin21.1.0, NS appkit-2113.00 Version 12.0.1 (Build 21A559)) of 2022-04-04 built on armbob.lan Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.4 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER THREADS TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $EMACSLOADPATH: /Users/tanzer/.emacs.lib::/Applications/Emacs.app/Contents/Resources/site-lisp: value of $LC_CTYPE: UTF-8 value of $LC_MESSAGES: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: desktop-save-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: /Users/tanzer/.emacs.lib/custom hides /Applications/Emacs-28.1.app/Contents/Resources/lisp/custom Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils desktop frameset cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 52547 9320) (symbols 48 6728 1) (strings 32 18877 2482) (string-bytes 1 635721) (vectors 16 14225) (vector-slots 8 194877 11238) (floats 8 22 51) (intervals 56 203 0) (buffers 992 10)) -- Christian Tanzer