From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#55635: `make-decoded-time' incorrectly sets DST to nil, it should be -1 (guess) Date: Mon, 13 Jun 2022 14:30:40 -0700 Organization: UCLA Computer Science Department Message-ID: <4ec38916-753e-be93-a08d-a4e7cc4dd86f@cs.ucla.edu> References: <940415ce-2e31-ae18-3e16-8fdc54504a67@gmail.com> <87o7zkbif3.fsf@gnus.org> <96e9d729-2e23-5637-3136-ac29e26aa287@cs.ucla.edu> <87r14f8dhw.fsf@gnus.org> <87zgj23pn9.fsf@gnus.org> <0e506652-fb7d-5707-8247-7747ff1e53b0@gmail.com> <83o7zhlht0.fsf@gnu.org> <87sfos1o3o.fsf@gnus.org> <6ce0d14a-017c-2b28-d924-fb461396c547@cs.ucla.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------glXCi8ppBKeDYa6GnQauSDdj" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28755"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: Eli Zaretskii , 55635@debbugs.gnu.org, Lars Ingebrigtsen To: Maxim Nikulin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 13 23:31:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0reQ-0007FW-7t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 23:31:10 +0200 Original-Received: from localhost ([::1]:60204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0reO-0003Kb-RD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 17:31:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0reI-0003KB-A8 for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 17:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0reH-0001w5-VA for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 17:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0reH-0006mk-Qi for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 17:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2022 21:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55635 X-GNU-PR-Package: emacs Original-Received: via spool by 55635-submit@debbugs.gnu.org id=B55635.165515585026063 (code B ref 55635); Mon, 13 Jun 2022 21:31:01 +0000 Original-Received: (at 55635) by debbugs.gnu.org; 13 Jun 2022 21:30:50 +0000 Original-Received: from localhost ([127.0.0.1]:60638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0re6-0006mI-A7 for submit@debbugs.gnu.org; Mon, 13 Jun 2022 17:30:50 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:48520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0re3-0006m2-FE for 55635@debbugs.gnu.org; Mon, 13 Jun 2022 17:30:49 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 00CAF1600FC; Mon, 13 Jun 2022 14:30:41 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id O1HYcwA3xwlG; Mon, 13 Jun 2022 14:30:41 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 02AA5160149; Mon, 13 Jun 2022 14:30:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hyeWC2pGDakR; Mon, 13 Jun 2022 14:30:40 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C4C061600FC; Mon, 13 Jun 2022 14:30:40 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234446 Archived-At: This is a multi-part message in MIME format. --------------glXCi8ppBKeDYa6GnQauSDdj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 5/31/22 05:25, Maxim Nikulin wrote: > I have never used `cl-defstruct' before (and frankly speaking I am=20 > rather confused that the `decoded-time' struct and its constructor=20 > `make-decoded-time' are defined in different files and even directories= =20 > are not the same), so my question may be na=C3=AFve. Why did not you ju= st add=20 > this new sentence to the :documentation property of the DST slot a bit=20 > above? I am not sure I understand the question. The slot itself has a specified=20 value (t, nil, or -1) whereas the decoded-time-dst function returns an=20 unspecified value when there is no slot. > By the way, after updating of `make-decoded-time', default value for DS= T=20 > should be updated in `cl-defstruct' as well, otherwise > =C2=A0=C2=A0=C2=A0 (describe-symbol 'decoded-time) > reports that the default is nil. >=20 > It may be reasonable to cross-link `decoded-time' and=20 > `make-decoded-time' in docstrings. Thanks for the suggestions; I installed the attached. --------------glXCi8ppBKeDYa6GnQauSDdj Content-Type: text/x-patch; charset=UTF-8; name="0001-Default-decoded-time-dst-slot-to-1.patch" Content-Disposition: attachment; filename="0001-Default-decoded-time-dst-slot-to-1.patch" Content-Transfer-Encoding: base64 RnJvbSA1Njc4ODI5YTYyNzUyZWIzMzJjYWVmM2FiZWJlYjY0Y2IwNzIyNzA4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDEzIEp1biAyMDIyIDE0OjI1OjU4IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gRGVmYXVsdCBkZWNvZGVkLXRpbWUgZHN0IHNsb3QgdG8gLTEKCiogbGlzcC9zaW1wbGUu ZWwgKGRlY29kZWQtdGltZSk6IERlZmF1bHQgZHN0IHNsb3QgdG8gLTEuCkltcHJvdmUgcmVs YXRlZCBkb2Mgc3RyaW5ncy4KLS0tCiBsaXNwL2NhbGVuZGFyL3RpbWUtZGF0ZS5lbCB8ICAz ICsrLQogbGlzcC9zaW1wbGUuZWwgICAgICAgICAgICAgfCAxNiArKysrKysrKysrLS0tLS0t CiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvbGlzcC9jYWxlbmRhci90aW1lLWRhdGUuZWwgYi9saXNwL2NhbGVuZGFy L3RpbWUtZGF0ZS5lbAppbmRleCA0MDM3NGMzYmI0Li5kMTkxMzRkYjgzIDEwMDY0NAotLS0g YS9saXNwL2NhbGVuZGFyL3RpbWUtZGF0ZS5lbAorKysgYi9saXNwL2NhbGVuZGFyL3RpbWUt ZGF0ZS5lbApAQCAtNTU3LDcgKzU1Nyw4IEBAIG1ha2UtZGVjb2RlZC10aW1lCiAgIChsaXN0 IHNlY29uZCBtaW51dGUgaG91ciBkYXkgbW9udGggeWVhciBuaWwgZHN0IHpvbmUpKQogCiAo ZGVmdW4gZGVjb2RlZC10aW1lLXNldC1kZWZhdWx0cyAodGltZSAmb3B0aW9uYWwgZGVmYXVs dC16b25lKQotICAiU2V0IGFueSBuaWwgdmFsdWVzIGluIGBkZWNvZGVkLXRpbWUnIFRJTUUg dG8gZGVmYXVsdCB2YWx1ZXMuCisgICJTZXQgbW9zdCBuaWwgdmFsdWVzIGluIGBkZWNvZGVk LXRpbWUnIFRJTUUgdG8gZGVmYXVsdCB2YWx1ZXMuCitUaGlzIGNhbiBzZXQgVElNRSdzIHll YXIsIG1vbnRoLCBkYXksIGhvdXIsIG1pbnV0ZSBhbmQgc2Vjb25kLgogVGhlIGRlZmF1bHQg dmFsdWUgaXMgYmFzZWQgb24gSmFudWFyeSAxc3QsIDE5NzAgYXQgbWlkbmlnaHQuCiBUaGlz IHllYXIgaXMgdXNlZCB0byBndWFyYW50ZWUgcG9ydGFiaWxpdHk7IHNlZSBJbmZvCiBub2Rl IGAoZWxpc3ApIFRpbWUgb2YgRGF5Jy4KZGlmZiAtLWdpdCBhL2xpc3Avc2ltcGxlLmVsIGIv bGlzcC9zaW1wbGUuZWwKaW5kZXggZjY5MzIzMzljOS4uMDVhMDg1NWE5NiAxMDA2NDQKLS0t IGEvbGlzcC9zaW1wbGUuZWwKKysrIGIvbGlzcC9zaW1wbGUuZWwKQEAgLTEwNTExLDEwICsx MDUxMSwxMCBAQCBjYXBpdGFsaXplLWR3aW0KICAgKHllYXIgbmlsIDpkb2N1bWVudGF0aW9u ICJUaGlzIGlzIGEgZm91ciBkaWdpdCBpbnRlZ2VyLiIpCiAgICh3ZWVrZGF5IG5pbCA6ZG9j dW1lbnRhdGlvbiAiXAogVGhpcyBpcyBhIG51bWJlciBiZXR3ZWVuIDAgYW5kIDYsIGFuZCAw IGlzIFN1bmRheS4iKQotICAoZHN0IG5pbCA6ZG9jdW1lbnRhdGlvbiAiXAorICAoZHN0IC0x IDpkb2N1bWVudGF0aW9uICJcCiBUaGlzIGlzIHQgaWYgZGF5bGlnaHQgc2F2aW5nIHRpbWUg aXMgaW4gZWZmZWN0LCBuaWwgaWYgaXQgaXMgbm90Ci1pbiBlZmZlY3QsIGFuZCAtMSBpZiBk YXlsaWdodCBzYXZpbmcgaW5mb3JtYXRpb24gaXMgbm90Ci1hdmFpbGFibGUuIikKK2luIGVm ZmVjdCwgYW5kIC0xIGlmIGRheWxpZ2h0IHNhdmluZyBpbmZvcm1hdGlvbiBpcyBub3QgYXZh aWxhYmxlLgorQWxzbyBzZWUgYGRlY29kZWQtdGltZS1kc3QnLiIpCiAgICh6b25lIG5pbCA6 ZG9jdW1lbnRhdGlvbiAiXAogVGhpcyBpcyBhbiBpbnRlZ2VyIGluZGljYXRpbmcgdGhlIFVU QyBvZmZzZXQgaW4gc2Vjb25kcywgaS5lLiwKIHRoZSBudW1iZXIgb2Ygc2Vjb25kcyBlYXN0 IG9mIEdyZWVud2ljaC4iKQpAQCAtMTA1MjQsOSArMTA1MjQsMTMgQEAgY2FwaXRhbGl6ZS1k d2ltCiA7OyBJdCBzaG91bGQgcmV0dXJuIC0xIGluZGljYXRpbmcgdW5rbm93biBEU1QsIGJ1 dCBjdXJyZW50bHkgcmV0dXJucwogOzsgbmlsIGluZGljYXRpbmcgc3RhbmRhcmQgdGltZS4K IChwdXQgJ2RlY29kZWQtdGltZS1kc3QgJ2Z1bmN0aW9uLWRvY3VtZW50YXRpb24KLSAgICAg KGFwcGVuZCAoZ2V0ICdkZWNvZGVkLXRpbWUtZHN0ICdmdW5jdGlvbi1kb2N1bWVudGF0aW9u KQotICAgICAgICAgICAgICJBcyBhIHNwZWNpYWwgY2FzZSwgYGRlY29kZWQtdGltZS1kc3Qn IHJldHVybnMgYW4gdW5zcGVjaWZpZWQKLXZhbHVlIHdoZW4gZ2l2ZW4gYSBsaXN0IHRvbyBz aG9ydCB0byBoYXZlIGEgZHN0IGVsZW1lbnQuIikpCisgICAgICJBY2Nlc3Mgc2xvdCBcImRz dFwiIG9mIGBkZWNvZGVkLXRpbWUnIHN0cnVjdCBDTC1YLgorVGhpcyBpcyB0IGlmIGRheWxp Z2h0IHNhdmluZyB0aW1lIGlzIGluIGVmZmVjdCwgbmlsIGlmIGl0IGlzIG5vdAoraW4gZWZm ZWN0LCBhbmQgLTEgaWYgZGF5bGlnaHQgc2F2aW5nIGluZm9ybWF0aW9uIGlzIG5vdCBhdmFp bGFibGUuCitBcyBhIHNwZWNpYWwgY2FzZSwgcmV0dXJuIGFuIHVuc3BlY2lmaWVkIHZhbHVl IHdoZW4gZ2l2ZW4gYSBsaXN0Cit0b28gc2hvcnQgdG8gaGF2ZSBhIGRzdCBlbGVtZW50Lgor CisoZm4gQ0wtWCkiKQogCiAoZGVmdW4gZ2V0LXNjcmF0Y2gtYnVmZmVyLWNyZWF0ZSAoKQog ICAiUmV0dXJuIHRoZSAqc2NyYXRjaCogYnVmZmVyLCBjcmVhdGluZyBhIG5ldyBvbmUgaWYg bmVlZGVkLiIKLS0gCjIuMzQuMQoK --------------glXCi8ppBKeDYa6GnQauSDdj--