From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Date: Fri, 01 Apr 2022 07:09:38 +1300 Message-ID: <4e51611a497c4fd3e7fab2c357d5cc3a@webmail.orcon.net.nz> References: <3947f11808243544dcdd4e4d2fde4922@webmail.orcon.net.nz> <875ynuh2rm.fsf@gmx.de> <87mth673io.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6525"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: Michael Albinus , 54606@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 31 20:34:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzd5-0001Vd-Bm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 20:34:43 +0200 Original-Received: from localhost ([::1]:59180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZzd4-0000th-DN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 14:34:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZzFC-0006Iu-EA for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 14:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZzFC-0000Jg-3o for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 14:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZzFB-0005Mw-Ty for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 14:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Mar 2022 18:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54606 X-GNU-PR-Package: emacs Original-Received: via spool by 54606-submit@debbugs.gnu.org id=B54606.164875018620609 (code B ref 54606); Thu, 31 Mar 2022 18:10:01 +0000 Original-Received: (at 54606) by debbugs.gnu.org; 31 Mar 2022 18:09:46 +0000 Original-Received: from localhost ([127.0.0.1]:39737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZzEw-0005ML-MC for submit@debbugs.gnu.org; Thu, 31 Mar 2022 14:09:46 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:54945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZzEv-0005MD-Br for 54606@debbugs.gnu.org; Thu, 31 Mar 2022 14:09:45 -0400 Original-Received: from [10.253.37.70] (port=45182 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1nZzEo-0001ni-LJ; Fri, 01 Apr 2022 07:09:39 +1300 Original-Received: from ip-139-180-65-103.kinect.net.nz ([139.180.65.103]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 01 Apr 2022 07:09:38 +1300 In-Reply-To: <87mth673io.fsf@gnus.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229174 Archived-At: On 2022-04-01 00:41, Lars Ingebrigtsen wrote: > Michael Albinus writes: > >>> Can we put some guards in there to decide whether or not dir >>> and default-directory are actually on the same host before >>> comparing them via file-truename? >> >> If you want to go *this* direction, there would be a simple change: >> >> (equal (file-remote-p dir) >> (file-remote-p default-directory)) >> >> file-remote-p doesn't do anything on wire. > > I think that sounds like a good change here anyway. Agreed -- if I'd checked to see what file-remote-p actually returned, I would done this myself from the outset. I've tested this approach in isolation, and it works well in my test instance. I've not yet tested to see whether the `non-essential' change is similarly efficient in a newer version with a similar session. Lars' suggestion of having these commands NOT checking every dired buffer every time also seems very sensible. -Phil