From: Phil Sainty <psainty@orcon.net.nz>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Michael Albinus <michael.albinus@gmx.de>, 54606@debbugs.gnu.org
Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers
Date: Fri, 01 Apr 2022 07:09:38 +1300 [thread overview]
Message-ID: <4e51611a497c4fd3e7fab2c357d5cc3a@webmail.orcon.net.nz> (raw)
In-Reply-To: <87mth673io.fsf@gnus.org>
On 2022-04-01 00:41, Lars Ingebrigtsen wrote:
> Michael Albinus <michael.albinus@gmx.de> writes:
>
>>> Can we put some guards in there to decide whether or not dir
>>> and default-directory are actually on the same host before
>>> comparing them via file-truename?
>>
>> If you want to go *this* direction, there would be a simple change:
>>
>> (equal (file-remote-p dir)
>> (file-remote-p default-directory))
>>
>> file-remote-p doesn't do anything on wire.
>
> I think that sounds like a good change here anyway.
Agreed -- if I'd checked to see what file-remote-p actually
returned, I would done this myself from the outset.
I've tested this approach in isolation, and it works well
in my test instance.
I've not yet tested to see whether the `non-essential'
change is similarly efficient in a newer version with a
similar session.
Lars' suggestion of having these commands NOT checking
every dired buffer every time also seems very sensible.
-Phil
next prev parent reply other threads:[~2022-03-31 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 10:13 bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Phil Sainty
2022-03-29 13:03 ` Lars Ingebrigtsen
2022-03-29 13:09 ` Michael Albinus
2022-03-30 11:43 ` Phil Sainty
2022-03-30 11:51 ` Michael Albinus
2022-03-30 12:03 ` Lars Ingebrigtsen
2022-03-31 9:47 ` Michael Albinus
2022-03-31 11:41 ` Lars Ingebrigtsen
2022-03-31 18:09 ` Phil Sainty [this message]
2022-04-01 7:06 ` Michael Albinus
2022-04-02 13:02 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e51611a497c4fd3e7fab2c357d5cc3a@webmail.orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=54606@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).