From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Tue, 25 Jul 2023 16:05:15 +0300 Message-ID: <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39095"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 25 15:06:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOHk2-0009tD-Ui for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jul 2023 15:06:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOHju-0006VL-8C; Tue, 25 Jul 2023 09:06:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOHjn-0006V3-4R for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 09:06:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOHjm-00018M-K3 for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 09:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOHjm-0004ss-Fe for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 09:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jul 2023 13:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169029032718706 (code B ref 64799); Tue, 25 Jul 2023 13:06:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 25 Jul 2023 13:05:27 +0000 Original-Received: from localhost ([127.0.0.1]:44876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOHjC-0004rd-L6 for submit@debbugs.gnu.org; Tue, 25 Jul 2023 09:05:26 -0400 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:48705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOHjA-0004rI-TH for 64799@debbugs.gnu.org; Tue, 25 Jul 2023 09:05:25 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 33A0B3200931; Tue, 25 Jul 2023 09:05:19 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 25 Jul 2023 09:05:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690290318; x=1690376718; bh=vFAbNYLAtsIbzGrYbNfe1RDI/u65qRyuYyq eYfJZB50=; b=M7oXubv1hkSE3+Ajkp5hL9XejM1txb/utkFuVxsAs8EtCc44LMQ 3+F4heZQX0Q42AH6M2f+2z1464yiGqHa60b24DSwFTiRbZlIikogW8dzw8RWMf0d vML0sGQJkDd3kcIFVYYGhjClQQBusI/waiSS/ZT+nbfybfaQGzsJIBeHxt5kRLI0 +VzmQYZyx61KXalEhlI8LepWyuIgj9wZ8rJup4ixea51N7+q6/7aHi2G2yoRoh9+ sopeaNhrW8KsngfLf+2g7cc1sFYsXij4ciPsIM27Q2UhD4KdzNXZY8swn891sb45 xqKVV+gnOYGf4icmZPsI8RbR8+ufj6G9XpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690290318; x=1690376718; bh=vFAbNYLAtsIbzGrYbNfe1RDI/u65qRyuYyq eYfJZB50=; b=elZ0oEPuZO+F30hKuvez0xe5mA+vJmwFEfO9bBYQYaz/DdwqBws sywfjTyiqDrKiPN/eJ+rMh5OOjLBeyK6YKIf8jHwBXISlNyRoddv1Yll7rYNqhz/ aSOixjYvjI6KwhwPllIbVjYXOL1YnyTOoK+Ru47v+eClFZmBSTz0cJJUhHP3jsfY h0kqLg2eQa65uBJRFZQhCpiYH/HXlqSSNYw2VXSS/dMNRf8XbFFbYJeMdT8EJYT4 KbaW8aXUL+D1/70txm7EYDG/e/BVKexvtFo+vsz8H1gi5Reg0/U6S1zxpTA9FywE GiQZHQEkyUWibl8H/2zgr30Vxkmn7Khlc6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedriedtgdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jul 2023 09:05:16 -0400 (EDT) Content-Language: en-US In-Reply-To: <87sf9cmr4x.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266058 Archived-At: On 25/07/2023 09:39, Philip Kaludercic wrote: >> Indeed, so if we switch to it in project.el, it will need some >> polyfill for Emacs 26-27. > > If there is interest, this face could be added to the Compat package, if > it would be OK to add Compat as a dependency for project.el on ELPA > (this would also mean that project.el wouldn't have to use a custom > `project--buffer-check'/`buffer-match-p' implementation). Good suggestion, but let's hold off on that still. > Alternatively, we could add a version/facep check and always prefer > `help-key-binding' if it is available, otherwise fall-back to the > current option. That works for me. >>> Perhaps a user option for the whole 'format' would be better? >> >> We can add a user option. But while we could also apply 'face' >> property on that option's string value, that doesn't seem like a very >> user-friendly approach toward someone who will want to change the face >> used (it will require some Lisp knowledge from the user). >> >> But a user option to change how the prompt text is constructed -- why >> not. E.g. one defaulting to "[%s] %s". > > Is there really such a wide range of options that users might be > interested in here? Protesilaos wanted to use a different format?