unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22926@debbugs.gnu.org
Subject: bug#22926: 24.5; `shell-command', `shell-command-default-error-buffer'
Date: Sun, 6 Mar 2016 13:30:59 -0800 (PST)	[thread overview]
Message-ID: <4e20bee2-3a48-44d1-8501-f19ccc660b0a@default> (raw)
In-Reply-To: <<83ziubv72j.fsf@gnu.org>>

> > 1. Doc string of `shell-command': Mention that you are prompted
> >    for the command.
> 
> Done.

Thx.

> > 2. `shell-command-default-error-buffer': Make it a user option.
> 
> Not sure it's necessary.

Why should it be an internal variable?  Did you check how it is used?

> > 4. Also, some lines in the doc string are too long (but not by
> >    much: 74 chars max instead of 70).
> 
> I don't see how this can be helped, as those lines generally
> reference symbols with long names.

Huh?  This is the longest line (but the mailer will perhaps wrap it):

 `start-process' directly, since it offers more control and does not impose

This is the second longest:

 In an interactive call, the variable `shell-command-default-error-buffer'

This the third longest:

 insert output in current buffer.  (This cannot be done asynchronously.)

None of those involves a symbol whose name is 68 or more chars.
They can all be shortened to 70 chars or less.

(All the other lines are 70 chars or less.)





       reply	other threads:[~2016-03-06 21:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<97b7c9cf-83fc-4d10-8f2b-836132fcc5ca@default>
     [not found] ` <<83ziubv72j.fsf@gnu.org>
2016-03-06 21:30   ` Drew Adams [this message]
2016-03-07 16:35     ` bug#22926: 24.5; `shell-command', `shell-command-default-error-buffer' Eli Zaretskii
     [not found] <<<97b7c9cf-83fc-4d10-8f2b-836132fcc5ca@default>
     [not found] ` <<<83ziubv72j.fsf@gnu.org>
     [not found]   ` <<4e20bee2-3a48-44d1-8501-f19ccc660b0a@default>
     [not found]     ` <<834mciuty3.fsf@gnu.org>
2016-03-07 16:52       ` Drew Adams
2016-03-06 15:14 Drew Adams
2016-03-06 17:40 ` Eli Zaretskii
2016-04-30 22:55   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e20bee2-3a48-44d1-8501-f19ccc660b0a@default \
    --to=drew.adams@oracle.com \
    --cc=22926@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).