From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Sheng Yang" Newsgroups: gmane.emacs.bugs Subject: bug#47150: [External] : bug#47150: 28.0.50; Incorrect major-mode in minibuffer Date: Mon, 19 Apr 2021 14:47:20 -0500 Message-ID: <4e10120a-58e8-4813-bc3d-975ecd19ad75@www.fastmail.com> References: <8cbe7629-2091-45d3-9424-46444d7a4633@www.fastmail.com> <887bda9c-906c-4163-a8db-08b45e021bfd@www.fastmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=a87d4db7c67d41cfa8e5fe4e05651b90 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.5.0-alpha0-380-gda4c716772-fm-20210419.004-gda4c7167 Cc: "47150@debbugs.gnu.org" <47150@debbugs.gnu.org>, Alan Mackenzie To: "Stefan Monnier" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 19 22:39:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYagR-0000IZ-06 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Apr 2021 22:39:51 +0200 Original-Received: from localhost ([::1]:36992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYagQ-0007tV-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Apr 2021 16:39:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYZsI-0004RR-NH for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 15:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYZsI-0004kF-FG for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 15:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYZsI-0001fN-D8 for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 15:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Sheng Yang" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Apr 2021 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47150 X-GNU-PR-Package: emacs Original-Received: via spool by 47150-submit@debbugs.gnu.org id=B47150.16188616736388 (code B ref 47150); Mon, 19 Apr 2021 19:48:02 +0000 Original-Received: (at 47150) by debbugs.gnu.org; 19 Apr 2021 19:47:53 +0000 Original-Received: from localhost ([127.0.0.1]:52165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYZs8-0001ey-MS for submit@debbugs.gnu.org; Mon, 19 Apr 2021 15:47:52 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYZs4-0001ei-61 for 47150@debbugs.gnu.org; Mon, 19 Apr 2021 15:47:52 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C53615C0186; Mon, 19 Apr 2021 15:47:42 -0400 (EDT) Original-Received: from imap2 ([10.202.2.52]) by compute6.internal (MEProxy); Mon, 19 Apr 2021 15:47:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=TP3GVsvd5/DVEDBHbfDsyuLQL4aY9J9 o9+ovl6TiMEY=; b=cBjVP51ww0wjlLXVohL2Si2d5zJW8bO5Z4UJjRlt7aC3Csm 8bk2aEbq1ACjciy38J7ZXjlahMCL70caKlHTZ8Q4uaPQqKw1BR8k9xJExrIA1+OL /zNhZRBiivgzJMy4HaE3ifnZNQ+D594IcTALr270a9ghNJ/P4fvdco7/MEN0Ee6c twKYOuU7Guv7pd9Aa3CfmxGyu1W+Zy9RMDbWjxtxCNk75KZ7uHzteo0znLVBS7Bv cC4e8FQLz8cVB0jev4v6qlmpZMoJGLk9SlZx9TP2etG/k7pS5n+xjjyEAyKqOQmK +hrr4U29pPZyYUPZ1ZbAmKXmCFcDYJCqs9GPkaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TP3GVs vd5/DVEDBHbfDsyuLQL4aY9J9o9+ovl6TiMEY=; b=Sic64RyOVmNm2evnUqvZ+n NH11sLR8hpogDBmFm7HV1/0ANqY2vuTgvhtWpmHjx3hl3DmlT+MzgOg4zMF+UaaQ DxznyeWy01gUmqpjIgC3iI3f7kLZ2tuo6usNgf3GGg4zoXCgyUlZeokHYhTmCAnj 04UapGX1D+el6O/FFi1yYUDsoVJCmb4cjAQ7UZN32Yvrqud06SDkVE94Egaw09Xy CJs8Ows1UZWzIvNhH61E0gLuhIf6UPaPNdkrlfgo6JYlf64XQgp1diS1Cc/OY5Wr TDUp9hf4VstIKoJ1ICFMEjElsE9nzxPnUuKrEqUv8kG71DNpLUN+3yJUOURM7QRA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtgedgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsegrtderreerreejnecuhfhrohhmpedfufhh vghnghcujggrnhhgfdcuoehsthihrghnghesfhgrshhtmhgrihhlrdgtohhmqeenucggtf frrghtthgvrhhnpeehleeutdduffffgeffieelteetvdduieehhfevgfdviedvtddtieef ieeggeevjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsthihrghnghesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id B4E43A00079; Mon, 19 Apr 2021 15:47:41 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204506 Archived-At: --a87d4db7c67d41cfa8e5fe4e05651b90 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable For telega, the check for minibuffer is a simple cl-assert, and I think = your suggestion of using `minibufferp` would be a better choice. For others, their test of minibuffer-inactive-mode is actually buried in= some variable `xxx-ignore-mode-list`, which is later checked by `(membe= r major-mode xxx-ignore-modes-list)`. My current modification is to add = `minibuffer-mode` to those variables. I assume this is the simplest solu= tion? Sheng On Mon, Apr 19, 2021, at 14:35, Stefan Monnier wrote: > > I managed to fix those by replacing (eq major-mode > > 'minibuffer-inactive-mode) with (derived-mode-p 'minibuffer-mode). W= hen this >=20 > Any reason why you won't use `minibufferp` instead, which seems more > reliable (and backward compatible to boot)? >=20 >=20 > Stefan >=20 >=20 Sheng Yang(=E6=9D=A8=E5=9C=A3), PhD Computer Science Department University of Maryland, College Park E-mail: styang@fastmail.com E-mail (old but still used): yangsheng6810@gmail.com --a87d4db7c67d41cfa8e5fe4e05651b90 Content-Type: text/html;charset=utf-8 Content-Transfer-Encoding: quoted-printable
For telega, the= check for minibuffer is a simple cl-assert, and I think your suggestion= of using `minibufferp` would be a better choice.

For others, their test of minibuffer-inactive-mode is actually bu= ried in some variable `xxx-ignore-mode-list`, which is later checked by = `(member major-mode xxx-ignore-modes-list)`. My current modification is = to add `minibuffer-mode` to those variables. I assume this is the simple= st solution?

Sheng

=
On Mon, Apr 19, 2021, at 14:35, Stefan Monnier wrote:
> I managed to fix th= ose by replacing (eq major-mode
> 'minibuffer-inactive-= mode) with (derived-mode-p 'minibuffer-mode). When this
Any reason why you won't use `minibufferp` instead, which s= eems more
reliable (and backward compatible to boot)?
<= /div>


     &n= bsp;  Stefan



Sheng Yang= (=E6=9D=A8=E5=9C=A3), PhD
Computer Sci= ence Department
University of Maryland= , College Park
E-mail: styang@fastmail.com
E-mail (old but still used): yangsheng6810@gmail.com
=

--a87d4db7c67d41cfa8e5fe4e05651b90--