unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: Sean Devlin <spd@toadstyle.org>, 58784@debbugs.gnu.org
Subject: bug#58784: 28.2; project-buffers incorrect under let-bound default-directory
Date: Wed, 23 Nov 2022 05:48:07 +0200	[thread overview]
Message-ID: <4d9dbe41-af65-ecde-1f92-d90d8f981d79@yandex.ru> (raw)
In-Reply-To: <86wn7ojqm8.fsf@mail.linkov.net>

On 21/11/22 20:24, Juri Linkov wrote:
>> So I just pushed that fix to master.
> Unfortunately, this change broke 'C-x p p g':
> 
>    @@ -1667,9 +1667,10 @@ project-switch-project
>    -    (let ((default-directory dir)
>    -          (project-current-inhibit-prompt t))
>    -      (call-interactively command))))
>    +    (with-temp-buffer
>    +      (let ((default-directory dir)
>    +            (project-current-inhibit-prompt t))
>    +        (call-interactively command)))))
> 
> Because 'C-x p p' switches to a temporary buffer, then
> 'g' calls 'project-find-regexp' and 'project--read-regexp'.
> But (thing-at-point 'symbol t) can't get a symbol at point
> in the empty temporary buffer.

Damn it. :-)

Thanks for noticing. I'll need a little time to think about the options, 
but we'll probably go with the previous proposed fix.





  reply	other threads:[~2022-11-23  3:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26  0:13 bug#58784: 28.2; project-buffers incorrect under let-bound default-directory Sean Devlin
2022-10-29  0:49 ` Dmitry Gutov
2022-10-31 17:47   ` Sean Devlin
2022-11-01 23:35     ` Dmitry Gutov
2022-11-02 15:18       ` Sean Devlin
2022-11-04  1:18         ` Dmitry Gutov
2022-11-04 16:39           ` Sean Devlin
2022-11-21 18:24       ` Juri Linkov
2022-11-23  3:48         ` Dmitry Gutov [this message]
2022-11-24  2:37           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d9dbe41-af65-ecde-1f92-d90d8f981d79@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=58784@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=spd@toadstyle.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).