From: Drew Adams <drew.adams@oracle.com>
To: 15666@debbugs.gnu.org
Subject: bug#15666: 24.3.50; regression: `defadvice' of a special form
Date: Sun, 20 Oct 2013 16:32:03 -0700 (PDT) [thread overview]
Message-ID: <4d8e56cc-f3ea-4cbb-b094-6b0ff3e37169@default> (raw)
In-Reply-To: <6bc447c6-2d04-47d5-9e55-c8e6362fd4c7@default>
> In Emacs 24 you get this:
> (error "Advice impossible: defconst is a special form")
And the code that raises that error has this comment:
(cond
((special-form-p def)
;; Not worth the trouble trying to handle this, I think.
(error "Advice impossible: %S is a special form" symbol))
"I think"? That does not justify this regression.
It was worth the trouble before it was broken, i.e., for a
couple of decades. Why go to the "trouble" of breaking it?
next prev parent reply other threads:[~2013-10-20 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 23:15 bug#15666: 24.3.50; regression: `defadvice' of a special form Drew Adams
2013-10-20 23:32 ` Drew Adams [this message]
2021-05-30 5:45 ` Lars Ingebrigtsen
2021-05-30 14:32 ` bug#15666: [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8e56cc-f3ea-4cbb-b094-6b0ff3e37169@default \
--to=drew.adams@oracle.com \
--cc=15666@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).