From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Thu, 20 Jul 2023 15:42:59 +0300 Message-ID: <4d4f029f-f32f-13df-ffc3-3952d62d8bb3@gutov.dev> References: <837cqv41ob.fsf@gnu.org> <87mszqixhh.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11088"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Spencer Baugh , 64735@debbugs.gnu.org To: sbaugh@catern.com, Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 20 14:44:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMT0w-0002eX-H6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jul 2023 14:44:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMT0m-0002rw-Kv; Thu, 20 Jul 2023 08:44:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMT0l-0002rT-1r for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 08:44:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMT0k-0000UY-Lg for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMT0k-000061-HA for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2023 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.168985698932761 (code B ref 64735); Thu, 20 Jul 2023 12:44:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 20 Jul 2023 12:43:09 +0000 Original-Received: from localhost ([127.0.0.1]:57941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMSzt-0008WL-Go for submit@debbugs.gnu.org; Thu, 20 Jul 2023 08:43:09 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:49359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMSzr-0008W4-0A for 64735@debbugs.gnu.org; Thu, 20 Jul 2023 08:43:07 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E9E9C5C0089; Thu, 20 Jul 2023 08:43:01 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 20 Jul 2023 08:43:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1689856981; x=1689943381; bh=7buN++tSPFVB6cJ+5C11cPD2buTnj18XMf+ 6YvmsJHU=; b=Y1CHSHW+cRmEMYugxT1OjEbR9FXLunZN7xPngGXI1IwRL4v/cl/ ytvU0KrlsmOg7GP7v/H0uQNbRlo43FHcyNkDDEsjFZuv6FmDeQBOijo4JMRd9G59 4RLQ6Zd/oIaVEKYcmWFYfO7zUDd/oP6qrKz0AwZpf1JfeaVUyuKUDcGM+6DTF+Zk 2rXG4QbU8TEPe/c8xETSzck/dkogZz9c7+N1K4hJcZqwnbBvp1NqHNVxZSq33LtV uZ+KmFuC/NNS3QF8MZKET1gQMUpLQXqgDDOBPCi822Tllyta5GSDI5rJ75nUdZ2/ g1sSrq+AzxB/jqH3A3yZaPBtZOrtAIyV1gQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1689856981; x=1689943381; bh=7buN++tSPFVB6cJ+5C11cPD2buTnj18XMf+ 6YvmsJHU=; b=MGntHloOtIKzkmlzfogInZkqLqeYo5IJLyetuQj+H26XqflBUxh 5GRzL7thcaMAWWlFxsF4vo2FUIET0hxTtXbMyuzjUm2SsPvLLtzOlDRfi1go+a5U tiIJi394QswMJz/kN7psPHXt3eDt3QJJySO5GCEUYdznna7oXj9L0LXF3A73spwN bh7TO05SWVuqbPAnQSP1IieVlEfWwjKcAnkGB2RqwAngTRRj2RsAypu1tRJaHqES DolTFMrkZSkc6B1IsgWCas/hlOaormJL4C7x1I2b7C9cwzo5gwQu50pBy9cDcwl6 t9lez3oglwQ0G3An1bELR659aShACKqh3uQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrhedtgdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Jul 2023 08:43:00 -0400 (EDT) Content-Language: en-US In-Reply-To: <87mszqixhh.fsf@catern.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265593 Archived-At: On 20/07/2023 15:22, sbaugh@catern.com wrote: >> I'm not sure we should bother more than these two simple measures. > Unfortunately those two simple measures help rgrep but they don't help > project-find-regexp (and others project.el commands using > project--files-in-directory such as project-find-file), since those > project commands pull their ignores from the version control system > through vc (not grep-find-ignored-files), and then pass them to find. That's only a problem when the default file listing logic is used (and we usually delegate to something like 'git ls-files' instead, when the vc-aware backend is used). Anyway, some optimization could be useful there too. The extra difficulty, though, is that the entries in IGNORES already can come as wildcards. Can we merge several wildcards? Though I suppose if we use a regexp, we could construct an alternation anyway. Another question it would be helpful to check, is whether the different versions of 'find' out there work fine with -regex instead of -name, and don't get slowed down simply because of that feature. The old built-in 'find' on macOS, for example.